FR: Events - pass in old data & and `is_dirty` boolean about ideas HOT 12 CLOSED

+1 for this.

from ideas.

As per discussion w/ Jesse in Discord, it would be even better if the event was only fired when there's changed/new data.

from ideas.

Perhaps related: statamic/v2-hub#2520

from ideas.

It might be better, just a thought.

Anyway, would like to see more practical examples of where you might actually use old data and/or dirty booleans in our data events? Providing old data to all of the events across our system could get messy.

from ideas.

Like I said above Jesse, it's to prevent a loop.

I'll try to find some code that I've used in the past.

from ideas.

Theoretically, you'd be able to prevent loops by hooking into EntrySaving and cancelling a save. These aren't all implemented yet, but the plan is that every data type will fire these events...

• EntrySaving (pre-save, with the ability to cancel save)
• EntrySaved (post-save)
• EntryDeleting (pre-delete, with the ability to cancel delete)
• EntryDeleted (post-delete)

(The Saved and Deleted events are coming soon with the new git integration feature. The Saving and Deleting events aren't in there yet, but coming at some point.)

from ideas.

How would I know to cancel the save if I don't know if anything has changed? So either we have to know if something has changed, or the event can't fire when nothing has changed.

from ideas.

Not saying that is the solution, just adding context to the discussion around events.

from ideas.

It's a lot simpler for Eloquent Models to check if they're dirty since they only have attributes and original arrays to worry about.

Perhaps the "saving" events are a better place for when you want to modify a thing. Then you don't have to re-save them.

from ideas.

I only want to things if the content has been saved though...validation passed, all Statamic stuff done etc.

from ideas.

This would be a very much appreciated addition! I've come across this a lot where I needed to check if a value has been changed or not. And only perform some logic when it did change. Right now I'm working around this with either some boolean values in the entry data or with some cache. But both feel very dirty and unreliable.

from ideas.

A similar exists boolean prop to determine whether an entity was deleted would be nice.

from ideas.