Minor Typo in emulate multi node about ml-engineering HOT 4 CLOSED

Thank you for flagging, Anindya - as you suggested fixed in:
a6aa601

from ml-engineering.

You can't create a branch on someone else's repo. You have to clone it first, please see: https://github.com/stas00/git-tools/tree/master/how-to-make-pr

from ml-engineering.

Thank you @stas00 . I meant I cloned, created a branch. Then wanted to push on that branch and create a PR. But could not push to that branch due to lack of permission. Anyway, since you already added, its sorted.

I was able to simulate 2 nodes on a GCP m/c following your code. I did have to do some additional trick with the public keys to enable passwordless ssh, but overall I followed your steps to test out the multi node simulation on a single m/c.

from ml-engineering.

Something must have gone haywire, since others have already made PRs into this repo https://github.com/stas00/ml-engineering/pulls?q=is%3Apr+is%3Aclosed - if you make another PR in the future and it happens again let's look together at why this is happening for you.

For simple one file small fixes I usually just do it directly in github - open the file -> edit -> save which makes PR - much faster - no need to use the fork - it does it for you.

Glad to hear it worked, Anindya. If you feel the trick you refer to might be useful to others please don't hesitate to PR it as well. and thank you!

from ml-engineering.