Giter Club home page Giter Club logo

Comments (5)

starek4 avatar starek4 commented on August 20, 2024

Seems good do it this way:
https://stackoverflow.com/questions/60174/how-can-i-prevent-sql-injection-in-php

from fly.

lyarenei avatar lyarenei commented on August 20, 2024

Thanks for the reference. But we will now have to get some SQL injections for testing the prevention. The simple ones which I managed to think about are not working. The server responds with error when execution assembled absolutely correct SQL query. Maybe it's just like php has some basic protection against them as you said.
I have conceptually modified one of the UserRepo class method to use the SQL stmt preparation, but I will leave this change locally at my PC, until we discover some SQL injections. I can, however, send you a copy if you want to.

from fly.

starek4 avatar starek4 commented on August 20, 2024

It needs to be protected. Only mysqli doesn't protect app properly.

Consider this PHP script. You can apply this injection on any column in our DB.

require_once(__DIR__ . "/db/Db.php");
$name = "admin' OR 1=1 -- ";
$db = new Db();
var_dump($db->Select("SELECT Pass FROM Users WHERE login = '$name' "));

from fly.

lyarenei avatar lyarenei commented on August 20, 2024

I think, I have completed injection prevention for Query method (proper testing needed, did some quick tests and it passed), but unfortunately Select doesn't go that well.

from fly.

lyarenei avatar lyarenei commented on August 20, 2024

All right, it should be all done and hopefully working without any problems.
Changes pushed in 99aaf30

from fly.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.