Comments (7)
Likely. However almost all human ships have the length as the longest edge, so at least it can be somewhat automated
Hercules series refutes this.
My suggestion is to have a table for each of the bugging ships to instruct the processing code what each side of the bounding box is.
Example
You have a ship that's 50m in width, 40m in length, 20m in height. (Complete bullshit, take a Hercules in mind) Right now the API thinks it's 40m in height and 20m in width)
So you make a table in json where the first value belongs to the largest number in the scale of the ship.
["width", "length", "height"]
The API or processing code would compare the width, height and length (scale) with eachother to make another table that's largest to smallest.
[50, 40, 20]
Now you can get make a dictionary by using the first json as the keys and the second as the values by index.
{
"width": 50,
"length": 40,
"height": 20
}
Keep in mind that are these values are fake and just for demonstration purposes, reply if you have a question or want to add something to my suggestion. 👍
from api.
Might it be best to implement my solution on the Unpacker?
from api.
Upon investigation, it seems that it is not an uncommon occurrence. The bounding box size in the data do not always follow the same orientation. The same issue can be found for the Carrack as well.
from api.
I hoped the Carrack would be the only outlier..
Seems like we'd need to manually define the orientation for each ship?
from api.
Likely. However almost all human ships have the length as the longest edge, so at least it can be somewhat automated
from api.
I like the idea, and think it would be best to fix this directly when creating the json files.
The sizes are handled here: https://github.com/StarCitizenWiki/scunpacked/blob/4bdb320fefd0be9479dc819afaa0228e0e911de7/Loader/ShipLoader.cs#L530
from api.
That'd be the best place to implement it, yes :)
from api.
Related Issues (20)
- Inconsistent damage between weapon variations HOT 1
- Improving the Weapon/Armour Responses HOT 5
- Adding data for bombs
- Adding data for location turrets HOT 2
- Adding data for fuel pods
- Some BEHR optics attachments is returning null in iron_sight HOT 2
- Expand FPS weapon attachment data HOT 4
- Animus Missile Launcher Magazine (3 cap) should report 3 as ammo count
- Empty item descriptions are arrays HOT 2
- Quikflare(pro)'s appearing in weapons endpoint HOT 2
- Add cryptokey description and stats
- Ships such as Hawk and Hurricane are returning 0 for sizes HOT 3
- Keywords like 85x pulls non related article. HOT 2
- Storm AA has no specified missiles attached to missile rack
- Size 3 tractor beams are marked as salvagehead in the type key HOT 1
- Making TractorBeam, SalvageModifier stats available HOT 4
- Consider adding more detailed stats for missiles HOT 1
- SQLSTATE[42S22]: Column not found: 1054 Unknown column 'sc_item_salvage_modifiers.uuid' in 'where clause'
- Manufacturers endpoint, has mis-named brands and duplicates HOT 1
- P8-AR returning 404 from items endpoint HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from api.