Comments (4)
Done! I haven't update the .readme in case other changes were getting wrapped up into the released version. If you want me to do that, feel free to add comments into the PR
from dbt-trino.
Relevant documentation:
https://docs.getdbt.com/docs/building-a-dbt-project/building-models/configuring-incremental-models#what-if-the-columns-of-my-incremental-model-change
from dbt-trino.
I've sorted my particular issue with an override macro using your function:
{% macro dbt_trino_get_append_sql(tmp_relation, target_relation) %}
{%- set dest_columns = adapter.get_columns_in_relation(tmp_relation) -%}
{%- set dest_cols_csv = dest_columns | map(attribute='quoted') | join(', ') -%}
insert into {{ target_relation }} ({{ dest_cols_csv }})
select {{dest_cols_csv}} from {{ tmp_relation.include(database=true, schema=true) }};
drop table if exists {{ tmp_relation }};
{% endmacro %}
Had to switch to use the tmp_relation to retrieve the columns and then add a list of fields to insert into otherwise data type mismatches happen when inserting ordinally
I did want to use an intersect function to only get fields that were in both destination and tmp but there aren't any built in jinja functions. I might throw a PR in to extend but for now this suits my needs
from dbt-trino.
@prgx-aeveri01 would you like to open a PR to fix incremental macro? Your snippet looks like a fix for the issue.
from dbt-trino.
Related Issues (20)
- Set the `comment` on `CREATE TABLE` HOT 3
- Double `describe table`
- Failing quote policy tests on galaxy HOT 3
- Add retry mechanism for the given error HOT 1
- Incremental model with on_schema_change='sync_all_columns' does not work with data type changes HOT 1
- Change full-refresh behaviour to drop target table after successful run HOT 2
- Include query_id in run results for seed HOT 1
- Invalid SQL generated for dbt_project_evaluator HOT 1
- dbt-trino adds comment into table create statement by default HOT 2
- dbt-Trino snapshot cannot create __dbt_tmp table after first run HOT 12
- Add tests for aliases
- Add copyright notices to files HOT 1
- Support elementary in improving data-quality capabilities HOT 3
- Extend Hive test coverage
- upgrade to support dbt-core v1.7.0 HOT 1
- Incorrect Schema Used When Renaming Materialized Views HOT 4
- Support CASCADE dropping relations
- Solving for large stage depths HOT 3
- Support `CREATE OR REPLACE` HOT 2
- get_relation not working as already_exists HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dbt-trino.