Giter Club home page Giter Club logo

Comments (26)

staniel359 avatar staniel359 commented on July 21, 2024

@gamersi Hello again.
Does this happen both on maximized and non-maximized window?

from muffon.

gamersi avatar gamersi commented on July 21, 2024

yes. but if i maximize it and press cmd + R then it reloads and fixes itself but only when it is in fullscreen

from muffon.

gamersi avatar gamersi commented on July 21, 2024

if you want i can send you a video via email

from muffon.

staniel359 avatar staniel359 commented on July 21, 2024

@gamersi Yes, please.
[email protected]

from muffon.

gamersi avatar gamersi commented on July 21, 2024

I sent it to you([email protected])

from muffon.

staniel359 avatar staniel359 commented on July 21, 2024

@gamersi Thank you.
That's weird.
Will try to figure this out.

from muffon.

staniel359 avatar staniel359 commented on July 21, 2024

@gamersi Does this happen on app start or after window resize?

from muffon.

gamersi avatar gamersi commented on July 21, 2024

On App Start
MacBook Pro 2019
macOS Ventura

from muffon.

staniel359 avatar staniel359 commented on July 21, 2024

@gamersi I see.
Too bad I don't have a Mac to test this bug.

Could you try installing earlier versions of the app and see when the bug starts to happen?
Maybe it is related to Electron version update.

from muffon.

gamersi avatar gamersi commented on July 21, 2024

I am going to try it now and will tell you the result of my research

from muffon.

gamersi avatar gamersi commented on July 21, 2024

Ok, I just tried version 2.0 and there were no such issues. it appears to affeact only version 3 and above.
And I just want to say that you should probably include a uninstaller for macos, bekause pkgs can be tricky to delete(I had to use AppCleaner to remove everything so that it could be reinstalled)

from muffon.

staniel359 avatar staniel359 commented on July 21, 2024

@gamersi Thanks for the hint.

There will be .dmg installer for the next version.
Are they easier to uninstall?

from muffon.

gamersi avatar gamersi commented on July 21, 2024

@gamersi Thanks for the hint.

There will be .dmg installer for the next version.

Are they easier to uninstall?

I would think so but could make problems with incompatible local data I think

from muffon.

staniel359 avatar staniel359 commented on July 21, 2024

@gamersi How do you usually uninstall apps on Mac and what extensions do installers have?

from muffon.

gamersi avatar gamersi commented on July 21, 2024

There are 3 common types of "installers"

  • Dmg: most popular, it has the packaged app as zip(number 3) and a reference to the applications folder. You simply drag the application to the referenced folder. To uninstall, you simply delete the zip(.app) out of the applications folder in the most cases
  • pkg: executable, kinda like a windows installer. Uninstalled must be manually provided unless the app does not use local storage, then it could theoretically be uninstalled in the applications folder just like the other ones
  • zip's(.app is shown in files): the content of dmgs, but it is not as convenient as dmg

This could give a few more info:
https://apple.stackexchange.com/questions/383730/how-do-you-uninstall-pkg-file

https://www.reddit.com/r/MacOS/comments/fmcfsh/dmg_pkg_and_zip_differences/

https://superuser.com/questions/604607/differences-between-dmg-and-various-zip-like-formats

But I can just speak from my experience as I just use Mac for my laptop not as my desktop os

from muffon.

staniel359 avatar staniel359 commented on July 21, 2024

@gamersi Got it, thank you.

Will try to fix the bug.

from muffon.

staniel359 avatar staniel359 commented on July 21, 2024

@gamersi I've made changes.
Could you test them on your system?

from muffon.

gamersi avatar gamersi commented on July 21, 2024

I just downloaded the newest src and I think isMac is not getting initialized properly:

A JavaScript error occurred in the main process
Uncaught Exception:
ReferenceError: isMac is not defined
at create (/Users/simon/Documents/code/muffon/electron/actions/tab/create.js:73:26)
at IpcMainImpl.handleAddTab (/Users/simon/Documents/code/muffon/electron/handlers/ipc/tab.js:24:3)
at IpcMainImpl.emit (node:events:527:28)
at EventEmitter. (node:electron/js2c/browser_init:165:11237)
at EventEmitter.emit (node:events:527:28)

from muffon.

staniel359 avatar staniel359 commented on July 21, 2024

@gamersi Oops, sorry.

from muffon.

gamersi avatar gamersi commented on July 21, 2024

It works fine now, but if you start/refresh it in fullscreen there is a bit too much spacing
image

from muffon.

staniel359 avatar staniel359 commented on July 21, 2024

@gamersi I see.
Could you send me a video of this behavior?
(You can attach it here).

from muffon.

gamersi avatar gamersi commented on July 21, 2024

unfortunately, the video is 40MB and the size limit on github is 10MB. I am going to send it via email as I already did yesterday

from muffon.

gamersi avatar gamersi commented on July 21, 2024

sent it

from muffon.

staniel359 avatar staniel359 commented on July 21, 2024

@gamersi Thank you.
I've made changes.
Could you check?

from muffon.

gamersi avatar gamersi commented on July 21, 2024

it works like a charm now.
Thanks

from muffon.

staniel359 avatar staniel359 commented on July 21, 2024

@gamersi Thank you for your help.

from muffon.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.