Giter Club home page Giter Club logo

Comments (4)

Supereg avatar Supereg commented on June 7, 2024 1

I'm not sure where the original rationale came from to refresh the token upon app start. I think it might make sense to keep that to e.g. have a smooth experience when there are external changes to your account.

But I agree, we should aim for getting the Account details ready faster (at least partially, e.g., it might take a while to load the user details from an external storage provider. Otherwise, we could choose to cache that on disk as well.)

from spezitemplateapplication.

PSchmiedmayer avatar PSchmiedmayer commented on June 7, 2024

@Supereg We have resolved this in the TBI app by adding the Firebase configuration module as a dependency of the Standard and manually using the Firebase functions to obtain a cached user.

It would be good to explore how we might automate that setup that Spezi Firebase Auth code and Account injection somehow is guaranteed to run before a HealthKit data type could arrive?

from spezitemplateapplication.

Supereg avatar Supereg commented on June 7, 2024

So what you are doing in TBI is directly accessing Auth.auth().currentUser which is present from the start?

What we currently do in SpeziFirebase is to force refresh the auth token upon app startup. This code was kept from the original version of SpeziAccount/SpeziFirebase. We could choose to remove that altogether, which should improve configuration time of the SpeziFirebase module. I assume, Firebase would automatically refresh the token before you do the next request.

from spezitemplateapplication.

PSchmiedmayer avatar PSchmiedmayer commented on June 7, 2024

Yes, that is the current approach we follow in TBI.

I think it is good to inject the account as early as possible. We can still do the token refresh once we already set the user as signed in and provided all the information right on the startup?

from spezitemplateapplication.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.