instruction.derefs_memory() doesn't check for implicit memory dereference about x64asm HOT 6 CLOSED

It would also be nice to have functionality to get the memory addresses touched. I think we've duplicated this logic in a few places (especially for pop/push) and it would be nice to centralize it.

from x64asm.

re: getting addresses touched --

This requires emulation of the source code, which isn't really something that this library is equipped to do. There is probably a place for this functionality somewhere in the stoke codebase, though. Probably somewhere in the sandbox, or in a class that uses sandbox callbacks.

from x64asm.

Oh, I probably wrote that wrong. What I really mean is memory
references that get touched. For example, 'push %rdx' is going to touch
-8(%rsp). That's something that can be returned as an x64asm::M64 or
something. Does that make sense to include here?

On 10/14/2014 03:32 PM, eric schkufza wrote:

re: getting addresses touched --

This requires emulation of the source code, which isn't really something that this library is equipped to do. There is probably a place for this functionality somewhere in the stoke codebase, though. Probably somewhere in the sandbox, or in a class that uses sandbox callbacks.

---

Reply to this email directly or view it on GitHub:
#38 (comment)

from x64asm.

re: implicit memory dereference

I can make this change. BUT. There's a semantic issue here, which is that I originally intended derefs_mem() to also imply that mem_index() would return non -1. Changing this to the semantics you want will break this invariant.

I'm going to leave derefs_mem(), but label it as deprecated, and replace it with three new methods:

is_implicit_memory_deref();
is_explicit_memory_deref();
is_memory_deref();

The semantics of is_explicit_memory_deref() will correspond to derefs_mem().

from x64asm.

back to touched addresses --

I see what you mean. I have to think about that one a little bit. There are some pretty strange corner cases that would make that a difficult method to write in full generality. Let's make that a separate issue and for now I'll just change the derefs_mem() thing.

from x64asm.

Closed.

from x64asm.