Comments (5)
This would be a long-term add, as it's not trivial.
from mobile.
I've been tinkering with a prototype to deliver this feature request, and I'd like to polish it up if the behavior and implementation are on the right track. I had to make some assumptions to get a prototype working, and added code comments to explain my reasoning. Have a look at the screenshots and this prototype branch and let me know what your thoughts are.
from mobile.
@shola this is pretty cool! You did it with less lines of code than I'd expect too. Although, I wish we could do this for the web/desktop app before we do it for mobile. Because doing it for mobile first is going to create a barrage of "why isn't this available on desktop??" (In note searching).
My concern with this is, what if the search term is not in the first two lines? Sort of a confusing interface then. Users will begin demanding that we clip out the relevant part from the note and display it in the results, prefixed with a "..."
Also, and this is where I'm torn: I haven't yet decided that mobile will be a "power" app. I'm reluctant to add features like this because it opens the door for more and more advanced features. The number one thing about mobile for me is that it has to be easy to maintain. You could have a 5 star app otherwise, but if you add in this one feature, and it doesn't work, you'll get 1-2 stars. So it's not always worth it.
If you're up for it, I'd love your help on adding in-note search highlighting on web/desktop. I think that would be much more useful.
from mobile.
I want to highlight the importance of this feature first: If you have a long note and you search for a term then the whole note comes in the result without highlighting where the term is. Now this is pretty much not useful at all for long notes specially, as i can't search that small term in that long note anyway afterwards easily. And personally, since I've many long notes I use this feature and depend on it very much in Colornote currently.
from mobile.
I think what @shola has demontrated above may not be appropriate though still very useful for when the results are few. If the results are many then how many of them will be shown on the top? One will have to go inside the note and attend to highlighted results individually anyway, as indicated in #83. But unlike #83, one should not be forced to search inside each note individually but that should happen after searching all the notes and then opening a result-note, and then the #83 methodology must be used.
from mobile.
Related Issues (20)
- Standard Notes from F-Droid crashing after upgrade HOT 29
- [BUG] crash on start since update HOT 2
- Problem with the Code Editor in Android
- Disable finger-print IF the phone do not have fingerpriny
- Unable to load editor on mobile HOT 20
- List-type notes don't get sorted by "Date modified" in Android version 3.16.0
- Disable auto-save HOT 2
- android app crashes using custom theme with non-plain-text editors
- Can't create folder on mobile HOT 2
- Add Orbot support
- Can't change note type after 3.20 update HOT 1
- Text Selection Handles do not appear on Minimal Markdown and Dynamic Markdown
- iOS version resets location every time leaving the app
- Cannot preview pdf files HOT 18
- Customs themes are not displayed after 3.20.1 update HOT 6
- Trashed archived notes don't show in Trash HOT 2
- Versioning date is wrong
- Display bug when opening the app
- Allow uploading files from other apps on Android via the Share mechanism
- Crash of v3.20.1 on Android 11
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mobile.