Guestbook does not inherit custom CSS styles about listed HOT 4 CLOSED

But I don't think the parent route's before_action runs for the sub-routes?

Tbh you'll just have to run and test the different scenarios, as it's been well over a year since I've been in this codebase, so can't really remember specifics.

a quick win

😵Quick win == technical debt.

But feel free to create the PR in the direction you would naturally take, and then we could discuss specifics on the PR itself.

from listed.

Would the fix be as simple as adding:

Seems like it! Perhaps we can add this to any author page that should be stylized and remove it from being exclusive to posts_controller.show method.

from listed.

Sounds good! Thanks for clarifying.

Looks like we already add the styles and meta images to all author pages in the authors_controller:

But I don't think the parent route's before_action runs for the sub-routes?

That's the only way I can explain the nested :guestbook path being the only one with no custom CSS or favicon. The nested :posts path required adding this to the posts_controller so that it didn't have the same issue (I think?):

@styles = @post.author.styles
set_meta_images_for_author(@post.author)

Even though similar code exists in the parent authors_controller.

I think a quick win would be to just add a similar code block to the guestbook_entries_controller's before_action.

Will make a PR, let me know if you're happy with the proposed changes.

from listed.

This one's probably been fixed with #68

from listed.