Comments (3)
It was a rookie mistake on my part just using int
in the beginning.
Rather than (1) or (2), how about:
- Replace all of the
int
types with the size-specific C++11int64_t
type.
I'd also be OK with a typedef set to that value if you think it may change again in the future. I'm not worried about mildly breaking backward compatibility in the case of a Stan program that relies on integer overflow behavior.
from stan.
This is blocked partially by our current IO mechanisms, since the model classes' write_array
serializes everything as a double.
Every int32 is representable in a double more-or-less exactly, but not every int64 is. For a classic example, 2^53 +1 is a totally valid integer, but it's nearest double representation is indistinguishable from 2^53
Now, @mitzimorris's ongoing look at re-thinking the IO has essentially already determined that this current way of doing things in write_array
needs to go if we want other nice features, so hopefully we won't need to worry about this when the time comes.
from stan.
Replace all of the int types with the size-specific C++11 int64_t type.
Yes I like that
This is blocked partially by our current IO mechanisms, since the model classes' write_array serializes everything as a double.
Ooof, did not know that.
Yeah this is not a huge rush thing and idt it will be a problem for the foreseeable future. We can certainly handle the problems around this until we are ready for this
from stan.
Related Issues (20)
- CompileError: command '/usr/bin/gcc' failed with exit code 1 HOT 6
- Pathfinder: unexpected behavior when num_draws < num_elbo_draws
- Implementation of improved Rhat for assessing convergence of MCMC
- Exception: In serializer: Storage capacity [763] exceeded while writing value of size [16] from position [759] HOT 6
- Too loose ASSERT_NEAR and wrong test values in compute_potential_scale_reduction_test.cpp HOT 3
- Allow some chains in multi chain samplers to fail during initialization HOT 3
- Round the Pathfinder Pareto k-value
- report condition number of metric for HMC adaptive samplers HOT 4
- Possible issue with new RNG? HOT 16
- Initialization failed message is misleading when using user defined inits
- FR: `model_base` methods - use `Eigen::Ref<Eigen::VectorXd>`
- Replace all non-finite lp__ and lp_approx__ with -Inf HOT 1
- Setting lower bounds and mutliplier at the same time HOT 1
- Review the Issues list please? HOT 2
- use improved Rhat to implement ESS-bulk and ESS-tail HOT 10
- Add boolean-based indexing (e.g., `Y[Z == 1]`) HOT 3
- stan_csv_reader should skip warmup draws
- Modify the opitimization lines earch to not return a point with non-finite gradient HOT 1
- Unexpected behaviour (to me) with declaring multiple transformed data HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from stan.