Incorrect column names in as.matrix.projection() about projpred HOT 6 CLOSED

So this is a bit tricky and I also realised that some models returned different names. It seems to happen with both multilevel models and models with contrasts, as the underlying projections have names for the contrasts.

I think your solution can partially solve the issue in some models but we still have the thing of fixing the group names, as in your example we recover my_group.(Intercept) and so on while we ideally want (Intercept | my_group), etc. I'll reply in your PR with this in case you want to address that as well?

from projpred.

I also thought about keeping the old column names style (from x$solution_terms, but re-ordered), but I have two other issues that I wanted to submit afterwards and whose fixes make sense with this new style of column names. I'll create PRs for those two new issues and then it might be easier to discuss the naming of the columns.

Thanks for the hint concerning contrasts. I will have to see whether my proposed fix has to be adapted for contrasts.

from projpred.

from projpred.

Yes, the same holds for my two other issues.

from projpred.

I also thought about keeping the old column names style (from x$solution_terms, but re-ordered), but I have two other issues that I wanted to submit afterwards and whose fixes make sense with this new style of column names. I'll create PRs for those two new issues and then it might be easier to discuss the naming of the columns.

Here are these two new PRs: #74 and #75.

from projpred.

Fixed by merged PR #75.

from projpred.