Giter Club home page Giter Club logo

Comments (5)

stalniy avatar stalniy commented on May 18, 2024

Yes, it could be. But this function doesn't do optimisation. It just follows the general rule: all regular rules are OR-ed.

So, in your case you have only 1 rules that's why they are identical. It's possible to optimise this if it's important for you. Just to check if $or contains only 1 element and there are no $and statements

from casl.

sarkistlt avatar sarkistlt commented on May 18, 2024

thanks for quick response, so if it will be can('read', ['products'], { id: 'someId', tid: 'someId' }), it will generate, { '$or': [ { id: 'someId', tid: 'someId' } ] }?
but in that case statement will be true if at least one if id or tid is matching but not both correct?

from casl.

stalniy avatar stalniy commented on May 18, 2024

No, $or works this way:

// this is equivalent  of
// (a === 1 && b === 2 ) || c === 3
{
  $or: [{ a: 1, b: 2 }, { c: 3 }]
}

Update: so in your case it will be the same as id === "someId" && tid === "someId

from casl.

sarkistlt avatar sarkistlt commented on May 18, 2024

I see, ok thanks, that work for me

from casl.

stalniy avatar stalniy commented on May 18, 2024

You are welcome! :)

from casl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.