Doesn't honor the NUGET_PACKAGES environment variable about specflow.netcore HOT 7 CLOSED

Fair one, really easy to implement. If @stajs doesn't beat me to it (and I remember) I'll take a crack later today.

from specflow.netcore.

Forgive me, I don't understand what the issue is. My best guess at what you are reporting, is that dotnet restore doesn't cache packages in the right location? If that is true, it seems a bug in either dotnet CLI or NuGet?

from specflow.netcore.

I think he is refering to us incorrectly assuming that nuget packages are located under userprofile/.nuget when we are trying to find the specflow executable. See lines 19 and 21 in Fixer.cs https://github.com/stajs/SpecFlow.NetCore/blob/master/src/SpecFlow.NetCore/Fixer.cs#L21

from specflow.netcore.

Ah, gotcha.

from specflow.netcore.

Apologies for the lack of clarity here.

Eric is correct. It is assumed that the path of the specflow exe is in the default location however if the NUGET_PACKAGES environment variable has been set then the location will be different.

If I get 5 minutes later today I'll create a pull myself if nobody beats to it.

Thanks for the quick responses guys.

from specflow.netcore.

Added a comment to the commit about falling through if the path fails, possibly a better option?

from specflow.netcore.

I was on the fence about it.

The first cut had it falling through, but it felt wrong - I thought if you had the environment variable set, you would want to know it isn't right?

Also added a --specflow-path argument in case you don't want to use an environment variable.

from specflow.netcore.