Giter Club home page Giter Club logo

Comments (10)

dennybaa avatar dennybaa commented on June 12, 2024

@armab I've already seen smth like this before. It must be a some kind of regression again. @Kami plz have a look if something changed in st2-register-content

from st2-packages.

arm4b avatar arm4b commented on June 12, 2024

Unrelated to this issue, but good to know also: StackStorm/st2#2314

from st2-packages.

dennybaa avatar dennybaa commented on June 12, 2024

Has @Kami already seen it? Because this problem actually happens because st2-register-content is trying to import st2actions module, however this module is not available in st2common package.

Actually I really don't get this circular dependency approach. Just look. St2actions depend on st2common this okay, further if you want to make st2actions available in st2common you make it circular)) I don't know how it is supposed to work when modules are separated, actually it can not work.
It only works with a single code tree, as soon as it gets split into pip modules or component packages it dies....

from st2-packages.

estee-tew avatar estee-tew commented on June 12, 2024

https://stackstorm.slack.com/archives/stackstorm/p1450699930016670

from st2-packages.

lakshmi-kannan avatar lakshmi-kannan commented on June 12, 2024

Hey @dennybaa, it appears @Kami made this change StackStorm/st2#1960 for packaging reasons. Originally we have st2actions depend on st2common and not the other way around. You said LGTM then :).

from st2-packages.

estee-tew avatar estee-tew commented on June 12, 2024

https://stackstorm.slack.com/archives/stackstorm/p1450729779016892

from st2-packages.

estee-tew avatar estee-tew commented on June 12, 2024

https://stackstorm.slack.com/archives/stackstorm/p1450798590017513

from st2-packages.

estee-tew avatar estee-tew commented on June 12, 2024

https://stackstorm.slack.com/archives/stackstorm/p1450798949017524

from st2-packages.

dennybaa avatar dennybaa commented on June 12, 2024

@lakshmi-kannan Oh lol. It worked, but somehow I've missed this code flow path :) @armab Has found it , thanks to him!

from st2-packages.

dennybaa avatar dennybaa commented on June 12, 2024

resolved thanks to @Kami

from st2-packages.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.