Comments (2)
Fixed by #133
from clarity-wasm.
Thanks for this work, @krl. Can we make the PoC repo public for others to take a look too?
After thinking about this a bit, I think your model would fit very easily into the current structure. You could tie into the traverse_list
in ast_visitor.rs, and instead of that large match
, you could use your lookup to get the trait for the right builtin. That would mean all of the implementations of traverse_*
and visit_*
in wasm_generator.rs move into their own individual files. Then if the word
is not found, then it must be a call to a user-defined function, and a call to a user-defined function could have its own trait implementation, which maps from the traverse_call_user_defined
method. That would indeed be a very nice re-structuring. If you can get on-board with that, then hold off on the two-phase compilation step until later, I think we could get it knocked out pretty quickly.
I'd love to hear input from @Acaccia and @cylewitruk on this. @zone117x, if you've dug into this code too, so if you're interested in taking a look and giving feedback that would be welcome as well.
from clarity-wasm.
Related Issues (20)
- Concat crosscheck regression HOT 4
- Wrong constant value in the signers.clar boot contract HOT 3
- Compilation error: Type mismatch: expected i32, found i64 HOT 1
- `sha512` results overwrite a litteral HOT 3
- Wrong result for `is-eq` for buffers with different max-len
- Utf-8 strings cannot be defined as data vars HOT 1
- issue with uint subtraction HOT 3
- var-get should throw a runtime error if variable does not exist
- principal-of? should throw a runtime error
- secp256k1-recover? should throw a runtime error
- secp256k1-verify runtime error handling
- add value to ShortReturnType runtime error
- Compilation errors handling
- Stdlib `$is-valid-string-ascii" does not account for all characters
- Validate `define-x` names
- Wrong evaluation order for tuples
- Crosscheck for `replace-at` fails too often due to `ValueTooLarge`
- Testing: `evaluate` and `interpret` should give access to the events
- Improve unit tests coverage for stx-transfer-memo? function HOT 4
- Improve unit tests for token functions HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from clarity-wasm.