Giter Club home page Giter Club logo

Comments (4)

hellohynes avatar hellohynes commented on August 20, 2024

I'm not understanding the problem @TedGoas. You can provide some problem examples?

from stacks.

TedGoas avatar TedGoas commented on August 20, 2024

@hellohynes We have a few notice styles. Here's another one from the docs site:

screen shot 2018-08-02 at 10 58 11 am


Let's agree we won't use the outline style here anymore. ๐Ÿ‘

Looking at the power blue example, here's the code:

<div class="grid ai-start gs4 s-notice s-notice__info mb48">
    <div class="grid--cell mr8">{% svg /resources/svg-icons/Alert.svg width="18" height="18" aria-hidden="true" class="svg-icon iconAlert" %}</div>
    <div class="grid--cell lh-lg">
        <strong>Note:</strong> The <code class="stacks-code bg-powder-200">unset</code> property is a combination property that resets a property to its inherited value. It behaves like the <code class="stacks-code bg-powder-200">inherit</code> and the <code class="stacks-code bg-powder-200">initial</code> keywords, but it properly selects the right value for you. Unfortunately, <code class="stacks-code bg-powder-200">unset</code> is not fully supported in Internet Explorer. Because of this all <code class="stacks-code bg-powder-200">unset</code> values have the correct <code class="stacks-code bg-powder-200">inherit</code> or <code class="stacks-code bg-powder-200">initial</code> value applied.
    </div>
</div>

There's some utility classes in there I think we can remove, or rather, move. Classes like mr8, lh-lg, and bg-powder-200. I'm suggesting we move stuff like this into a higher level class so we don't have to inline style each individual notice.

from stacks.

hellohynes avatar hellohynes commented on August 20, 2024

I don't agree that we should not use outlined style on the Stacks site. It's a Stacks style.

Going through the utility classesโ€ฆ

  • You don't need mr8 on grid-cell. Use gs8 on the wrapping grid and you get the same effect
  • Add lh-lg to the wrapping s-notice
  • Unfortunately if you want to change the background color on stacks-code you will have to apply a different class. What's the problem using the default gray background?

from stacks.

TedGoas avatar TedGoas commented on August 20, 2024

@hellohynes FWIW that isn't my code.

I'm suggesting we standardize the default style because we're currently styling each of them inline and it's not scaling well (I have to redo a bunch of notices that should match but don't).

from stacks.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.