Default settings exclude stac_version from the Landing page. about stac-fastapi HOT 4 CLOSED

I also came across https://api.stacspec.org/v1.0.0-beta.1/core/#operation/getLandingPage.

https://github.com/TomAugspurger/stac-fastapi/tree/fix/landing-stac-version has a test that we match that spec. There are some missing things

>       assert result == expected
E       AssertionError: assert {'description...ion', 'title'} == {'conformsTo'...version', ...}
E         Extra items in the right set:
E         'conformsTo'
E         'id'
E         Full diff:
E           {
E         -  'conformsTo',
E            'description',...
E
E         ...Full output truncated (7 lines hidden), use '-vv' to show

tests/resources/test_conformance.py:12: AssertionError

For at least id, I think that's because the version of stac-pydantic pinned here is too old to include stac-utils/stac-pydantic#43. I see stac-utils/stac-pydantic#45 might be addressing the conformsTo issue.

from stac-fastapi.

I think this is because the landing page sets response_model_exclude_unset=True. If I make this change

This is the case. It's kind of a weird interaction in pydantic that I wasn't aware of, where a default value that is set as a constant is excluded from the model output because technically it is not set.

import pydantic


class MyModel(pydantic.BaseModel):
    const: str = pydantic.Field("stac-version", const=True)


inst = MyModel()
print(inst.json(exclude_unset=True))

>>> {}

I'd rather fix this upstream in stac-pydantic so that stac_version is returned even if the response_model_exclude_unset is set, since its definitely a field that should always be returned. I'm sure this is also a problem in Items and Collections.
Speaking of stac-pydantic, I have some time planned this week to update it to the latest version of the spec, at which point I think it makes sense to update this project to use the latest stac-pydantic version, which would contain a fix to this issue as well as the other stac-pydantic issues you mention.

from stac-fastapi.

This same behavior is also removing the geojson type fields from the payload for similar reasons.

from stac-fastapi.

This is sort of fixed now that the api defaults to not using pydantic models to validate responses which skips this behavior. Closing for now but please feel free to reopen if this comes up again.

from stac-fastapi.