Failed to create output folder about screenrecorderlib HOT 7 CLOSED

Sounds like a problem with write access. Does it happen if you run it as administrator?

from screenrecorderlib.

I had same issue and run as administrator doesn't help.
My case:

1. if I run program in debug mode from Visual studio then everything is OK and I can record video
2. if I run program from debug\release folder directly then I get error from "utilities.h -> static bool CreateAllDirs(std::wstring path) -> BOOL result = CreateDirectory(path.substr(0, pos).c_str(), nullptr);" BUT if I use record to stream checkbox then everything is OK again
3. if I deploy program with wix installer then install it then everything is OK again...

Once I faced this error in Visual studio debugging mode. I tried different settings for project and when I changed Windows SDK version back and forth then magically error disappeared and now I have only case №2 left.
The thing is that most of our users not facing this error but around 1 from 10000 gets it and I have no idea why.

from screenrecorderlib.

This is really weird. I don't understand why Directory.CreateDirectory from c# and CreateDirectory from c++ should behave differently. I pushed commit 3056ea7 where i replaced CreateDirectory with std::filesystem::create_directories, and also made it print the error message in the error return. Please test it and see if it fixes your issue.

from screenrecorderlib.

Just tested it, works like a charm in any case from above.
One note: std::filesystem::create_directories(directory, ec) returns false if directory already exists so I changed code a bit.

from screenrecorderlib.

	std::error_code ec;
	if (std::filesystem::exists(directory))
	{
		LOG(L"output folder is already exists");
		m_OutputFolder = directory;
	}
	else
	{
		if (std::filesystem::create_directories(directory, ec))
		{
			LOG(L"output folder is ready");
			m_OutputFolder = directory;
		}
		else
		{
			// Failed to create directory.
			ERR(L"failed to create output folder");
			if (RecordingFailedCallback != nullptr)
				RecordingFailedCallback(L"Failed to create output folder: " + utilities::s2ws(ec.message()));
			return E_FAIL;
		}
	}

from screenrecorderlib.

Ah.. Thanks for the heads up. I'll push a new release with the changes then.

from screenrecorderlib.

Fixed with c37cd96

from screenrecorderlib.