15.0.4 doesn't work on ARM64 Macs. about clang-format-wheel HOT 9 CLOSED

Yes, the 14.0.6 version works fine.

from clang-format-wheel.

+1 to this - running pip install clang-format installs clang_format-15.0.4-py2.py3-none-macosx_10_9_universal2.whl, which, as its name suggests, should be universal, but the installed bin is only compiled for x86:

> file /opt/homebrew/lib/python3.10/site-packages/clang_format/data/bin/clang-format
/opt/homebrew/lib/python3.10/site-packages/clang_format/data/bin/clang-format: Mach-O 64-bit executable x86_64

from clang-format-wheel.

Thanks for reporting @Cyberbeni. I have identified an issue with linking ZLib (previous versions did not link against Zlib) and fixed it by disabling ZLib support (I doubt it is required for clang-format). Could you try to install clang-format from these wheels and run the executable? I have no access to an ARM64 Mac to try myself.

from clang-format-wheel.

Still crashes for me.

> python3 -m pip install --user ~/Downloads/wheels_without_zlib/clang_format-15.0.4-py2.py3-none-macosx_10_9_universal2.whl
Processing /Users/benedek.kozma/Downloads/wheels_without_zlib/clang_format-15.0.4-py2.py3-none-macosx_10_9_universal2.whl
Installing collected packages: clang-format
Successfully installed clang-format-15.0.4
> python3 -c 'from clang_format import clang_format; clang_format();'
dyld[71144]: Library not loaded: '/usr/local/opt/zstd/lib/libzstd.1.dylib'
  Referenced from: '/Users/benedek.kozma/Library/Python/3.10/lib/python/site-packages/clang_format/data/bin/clang-format'
  Reason: tried: '/usr/local/opt/zstd/lib/libzstd.1.dylib' (no such file), '/usr/local/lib/libzstd.1.dylib' (no such file), '/usr/lib/libzstd.1.dylib' (no such file)

If I install clang-format through Homebrew, that works correctly, the brew formula has uses_from_macos "zlib" which I think means that the OS should already have zlib installed (and there is also no sign of it installing zlib when I install clang-format through brew). Don't know if it helps but here is how they build it: https://raw.githubusercontent.com/Homebrew/homebrew-core/e0433f7392fb27e1aa51df6df1a6e3dfae2a31b1/Formula/clang-format.rb

from clang-format-wheel.

Have you successfully used prior versions of the Python package? If not, can you check? Would be helpful to know if it is a regression or a bug that has always been there and is exposed in your environment.

from clang-format-wheel.

I don't really understand why the official releases don't have every platform/arch for every release. 15.0.3 is the last one that has both x64 and arm64 for macOS, the later ones (15.0.4-15.0.6) only have arm64: https://github.com/llvm/llvm-project/releases

But if it had both, it would probably be better to just download those instead of rebuilding them IMO. (The lipo CLI tool can merge the 2 binaries)

from clang-format-wheel.

@Cyberbeni @psobot thanks for the feedback, if possible could you try this test version from the test pypi repo?:

pip install -i https://test.pypi.org/simple/ clang-format==15.0.6.2

Both the libzstd library issue and the missing arm64 architecture should be fixed, but I don't have access to an arm64 mac to test it.

from clang-format-wheel.

this seems to work fine for me

from clang-format-wheel.

@Cyberbeni thanks for testing it, there's now a 15.0.6 release on pypi with these fixes

from clang-format-wheel.