Comments (14)
Nope. In the previous release, we used cobra instead of go-cli. It uses posix style by default and doesn't support /
. I agree with Carlos on forcing posix in go-cli to keep behavior the same as before.
from engine-deprecated.
I have fixed some bugs & merged in master as you could see.
But we have more problems:
go-cli
uses/flag
format for options instead of--flag
as it was before, are we ok with it?- we have changed how errors are displayed. Now they escape
\
and tests are failing - some sql tests are failing now. Because queries like
/*_comment_*/_show_tables;
are parsed like unknown flags now. What do we want to do about it? TestWebTestSuite/TestSQL
fails withcould not prune components: unable to remove all containers: container not found
now sure why- logs are ugly now:
from engine-deprecated.
go-cli
uses/flag
format for options instead of--flag
as it was before, are we ok with it?- some sql tests are failing now. Because queries like
/*_comment_*/_show_tables;
are parsed like unknown flags now. What do we want to do about it?
From jessevdk/go-flags docs, we can change it to be --opt
with the build tag forceposix
.
We can change it in run-integration-tests.bat
(go build -tags forceposix
) and Makefile
(GO_TAGS = forceposix
)
TestWebTestSuite/TestSQL
fails withcould not prune components: unable to remove all containers: container not found
now sure why
This one looks like the most important problem to me.
from engine-deprecated.
go-cli
uses/flag
format for options instead of--flag
as it was before, are we ok with it?- some sql tests are failing now. Because queries like
/*_comment_*/_show_tables;
are parsed like unknown flags now. What do we want to do about it?
If the windows user is more familiar with /
instead of -
I'd keep this behavior. WRT the tests I think that it makes sense to have different test builds for Windows. In this /*_comment_*/_show_tables;
case on windows is actually expected that it raises an unknown flags error.
- looks like
StreamLinifier
doesn't support windows correctly (most probably due to\r\n
instead of '\n'). Tests are failing.
This seems to be an easy fix.
TestWebTestSuite/TestSQL
fails withcould not prune components: unable to remove all containers: container not found
now sure whyThis one looks like the most important problem to me.
Yup, I agree 😕.
from engine-deprecated.
go-cli
uses/flag
format for options instead of--flag
as it was before, are we ok with it?- some sql tests are failing now. Because queries like
/*_comment_*/_show_tables;
are parsed like unknown flags now. What do we want to do about it?If the windows user is more familiar with
/
instead of-
I'd keep this behavior.
If this was the first windows release, it would make sense. But in this case it is a breaking change that we can avoid easily, and as an extra it probably takes less effort to add this build tag than adapt the tests to work differently on windows.
from engine-deprecated.
If this was the first windows release, it would make sense. But in this case it is a breaking change that we can avoid easily.
Isn't it the opposite? I mean we already have a released version (though experimental), so if we use the forceposix
tag we will break the usage of /
that is how it works now.
from engine-deprecated.
If this was the first windows release, it would make sense. But in this case it is a breaking change that we can avoid easily.
Isn't it the opposite? I mean we already have a released version (though experimental), so if we use the
forceposix
tag we will break the usage of/
that is how it works now.
But 0.11 and 0.12 already use the --opt
style. If we change it to /opt
in 0.13 it's a breaking change.
from engine-deprecated.
But 0.11 and 0.12 already use the --opt style. If we change it to /opt in 0.13 it's a breaking change.
Yup, sorry I tried on master
😅.
from engine-deprecated.
BTW it seems that now both options are working, so it wouldn't be a real breaking change except for the fact that it won't be explained in the usage.
from engine-deprecated.
#459 addresses all issues except for the ugly log.
- looks like
StreamLinifier
doesn't support windows correctly (most probably due to\r\n
instead of '\n').
AFAIR not it is used only for interactive repl testing, but they're skipped for Windows.
from engine-deprecated.
StreamLinifier
but when I run tests they failed on windows. Not tests that use this struct but the test for the struct itself.
from engine-deprecated.
Not tests that use this struct but the test for the struct itself.
Ah ok, right! 😅 For some reason they're passing now 👍, I don't remember if they were failing when I started working on this.
from engine-deprecated.
Fix for logs was merged in go-log.
from engine-deprecated.
Everything seems to work now except the log colors. The code in src-d/go-log#16 did not fix the output in Engine.
I created #462 to keep track, we can close this issue.
from engine-deprecated.
Related Issues (20)
- Make SQL interactive REPL testing work on Windows
- Use `icmd` to test interactive SQL REPL HOT 2
- SIGSEGV on `srcd sql` on macOS HOT 2
- Document more clearly that docker toolbox is not supported
- Handle missing docker desktop or docker toolbox installation. HOT 6
- Migrate from bblfsh/client-go to bblfsh/go-client
- Mount gitbase workdir as readonly
- New command to edit the config file
- Make use of regression tests
- Update to gitbase 0.20 beta
- docs: provide links to what's supported on gitbase HOT 1
- TestInteractiveREPL is flaky
- Update bblfshd to v2.12.1 HOT 5
- Tagging the latest built image also with `dev-latest` HOT 3
- Use "short" names for components HOT 2
- Broken TOC in the README HOT 2
- Question: user name and password for gitbase? HOT 2
- Log messages use broken color characters on windows
- Error attempting to open web parse/SQL HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from engine-deprecated.