Side effects of getScore and showSolutions break Question Type Contract about h5p-advanced-blanks HOT 4 CLOSED

Thanks for raising this issue. This means getScore should only calculate the current score and not do anything else? Should be doable to fix this.

from h5p-advanced-blanks.

@sr258 Well, some people have been asking why Advanced Fill in the Blanks might not be included in other content types yet, so I just had a look :-).

And yes, getScore() should really only return the score. showSolutions() should really only show the solutions (and the scorebar) but definitely not trigger xAPI statements like "answered" or "completed". For instance, Question Set is using those functions to control its children. You wouldn't want to resend AFTB's "answered" statement that would be emitted on check again when people go to Question Set's summary screen and possibly again when they check the solutions.

I might find time for a pull request after X-Mas if you prefer that.

from h5p-advanced-blanks.

I‘d be happy about a PR if you have the time for it. I‘m not really well-versed in the required xAPI behavior.

I‘ve already tested the content type‘s behavior when embedding it some time ago (actually pretty long ago) in other content and there were issue with rendering it in one of the more complex ones (forgot at the moment which one it was). I think this is caused by the way Ractive is initialized. I‘m not terribly happy with using Ractive at all anymore. It can‘t be updated easily, because of breaking changes in newer versions, so I‘m considering switching to React. Maybe I‘ll find the time for this in January...

from h5p-advanced-blanks.

@sr258 I'll see if I find some time. But the issue is not really with xAPI. It's fine in onCheckAnswer which checks the clozes, triggers xAPI, and shows the feedback. That's absolutely perfect when the user hits the check button, but that function is also called by getScore and showSolutions where you wouldn't want all of those things to happen. So it's really just about untying that.

from h5p-advanced-blanks.