Comments (2)
Based on the information you provide this seems like a very contrived example. You suggest it is a potential vector for a denial-of-service attack but only in the situation where:
- Someone is providing PHPCodeSniffer as a service in production
- There are no limits on the request to protect
- They are allowing CSS to be fed into a static analysis tool for PHP
This seems like a totally unrealistic example and nowhere near the normal use case for PHPCodeSniffer. Why are you feeding CSS into a tool for PHP?
from php_codesniffer.
@npr-gh @martinjoiner Well, PHPCS does currently still handle CSS and JS (up to a point), but the PHPCompatibility rulesets never have, nor will.
As per the readme on those projects: use --extensions=php
when running the PHPCompatibility rulesets.
Or if combined with other rulesets, use the below in a custom ruleset to limit PHPCompatibility to PHP files:
<rule ref="PHPCompatibilityWP">
<include-pattern>*\.php$</include-pattern>
</rule>
(though the problem is likely to be in the CSS tokenizer, but as that will be removed in v4, this is unlikely to be fixed)
On another note: don't open issues in this repo anymore, use the new repo instead. See #3932.
from php_codesniffer.
Related Issues (20)
- False positives for exception expression HOT 2
- PSR2.Methods.FunctionCallSignature.Indent cannot be exclude from command line HOT 2
- How to remove errors for specific comment or regex type string in a comment HOT 5
- Squiz.WhiteSpace.OperatorSpacing incorrectly adds space after bitwise operator HOT 3
- Generic.Files.LineLength miscalculates the length of line containing multibyte characters HOT 1
- Unnecessary line wrapping with `-s`
- PHP 8.3 - Typed class constants support HOT 6
- JavaScript: Indentation after object parameter HOT 2
- Auto fix of Squiz.Formatting.OperatorBracket.MissingBrackets is incorrect when working with ?? operator
- > Where Excel file import in codeigniter, the problem exists for phpexcel 1.8.0 on PHP 7 HOT 1
- The Future of PHP_CodeSniffer HOT 58
- PSR12.Files.FileHeader.SpacingAfterBlock: false positive when `use` is used for class and function HOT 1
- [PHP8.3] "final public const string JOURNEY" leads to "Class constants must be uppercase" HOT 4
- Allow lines to be longer than 80 chars if they're the first line in multi-line comments or part of annotations HOT 3
- Can't disable rule Underscore HOT 3
- Generic.WhiteSpace.ScopeIndent.IncorrectExact false positive in foreach with heredoc HOT 1
- Alignment incorrect (maybe?) for null coalesce assignment followed by normal assignment HOT 3
- readonly class: Expected 0 spaces before class keyword; 1 found HOT 2
- Code Sniffer works on one project but fails on others
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from php_codesniffer.