We've had a lot of crashes coming from this library on Android 11 and vivo dev

Thank you for taking a look and thanks for this library. <span cla

If this private field was added in 2011, but <a class="user-mention notranslate" data-

Hi <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="

Version 2.0.0 is crashing about radiography HOT 7 CLOSED

square commented on May 29, 2024 1

Version 2.0.0 is crashing

from radiography.

Comments (7)

pyricau commented on May 29, 2024 1

Checking if compose is available by calling ComposeViews.isComposeAvailable causes the loading of the ComposeViews which causes the init of the VIEW_KEYED_TAGS_FIELD field:

private val VIEW_KEYED_TAGS_FIELD = View::class.java.getDeclaredField("mKeyedTags")

https://github.com/square/radiography/blob/main/radiography/src/main/java/radiography/internal/ComposeViews.kt#L15

This private field was added in 2011 https://cs.android.com/android/_/android/platform/frameworks/base/+/7db82acd8151684a886d4725ddf2790ef3a2f80e:core/java/android/view/View.java;dlc=e94d950d122005bb10e11dd18b6029d0108f2fbe

cc @zach-klippenstein we should probably do two things:

maybe don't init the rest of the class helpers when compose isn't in the classpath
Degrade gracefully if we can't find this field?

from radiography.

zach-klippenstein commented on May 29, 2024 1

Planning to release today.

from radiography.

zach-klippenstein commented on May 29, 2024

We should definitely just fail gracefully if it's not found, all this reflection stuff should be as forgiving as possible.

from radiography.

yoavgray commented on May 29, 2024

Thank you for taking a look and thanks for this library.

…

On Wed, Jan 20, 2021, 10:49 AM Zach Klippenstein ***@***.***> wrote: We should definitely just fail gracefully if it's not found, all this reflection stuff should be as forgiving as possible. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#119 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABC3T4A3ZDPDFESYJFIRUQTS233PHANCNFSM4WGQBEAQ> .

from radiography.

zach-klippenstein commented on May 29, 2024

If this private field was added in 2011, but @yoavgray is seeing crashes on Android 11, which definitely has this field. I guess just vivo devices don't? Anyway, PR is up to fail gracefully: #122.

from radiography.