Giter Club home page Giter Club logo

Comments (3)

yschimke avatar yschimke commented on June 2, 2024 1

Attempting a fix to make it just work with constructors also

#8191

from okhttp.

yschimke avatar yschimke commented on June 2, 2024

I'll update the docs.

The issue is the model of Junit 5 parameters is different for constructors (class) and test and lifecycle methods (class/test method).

It's simplest to only support the latter to avoid confusion of people using the API correctly, but getting weird results.

This log won't make sense, but just recording for my notes.

resource id  [engine:junit-jupiter]/[ExtensionLifecycleTest]
init 
resource id  [engine:junit-jupiter]/[ExtensionLifecycleTest]/[method:testClient2(mockwebserver3.MockWebServer)]
resource id  [engine:junit-jupiter]/[ExtensionLifecycleTest]/[method:testClient2(mockwebserver3.MockWebServer)]
setup 
resource id  [engine:junit-jupiter]/[ExtensionLifecycleTest]/[method:testClient2(mockwebserver3.MockWebServer)]
testClient2 
resource id  [engine:junit-jupiter]/[ExtensionLifecycleTest]/[method:testClient2(mockwebserver3.MockWebServer)]
tearDown 
resource id  [engine:junit-jupiter]/[ExtensionLifecycleTest]/[method:testClient2(mockwebserver3.MockWebServer)]

resource id  [engine:junit-jupiter]/[ExtensionLifecycleTest]
init 
resource id  [engine:junit-jupiter]/[ExtensionLifecycleTest]/[method:testClient(mockwebserver3.MockWebServer)]
resource id  [engine:junit-jupiter]/[ExtensionLifecycleTest]/[method:testClient(mockwebserver3.MockWebServer)]
setup 
resource id  [engine:junit-jupiter]/[ExtensionLifecycleTest]/[method:testClient(mockwebserver3.MockWebServer)]
testClient 
resource id  [engine:junit-jupiter]/[ExtensionLifecycleTest]/[method:testClient(mockwebserver3.MockWebServer)]
tearDown 
resource id  [engine:junit-jupiter]/[ExtensionLifecycleTest]/[method:testClient(mockwebserver3.MockWebServer)]

from okhttp.

yschimke avatar yschimke commented on June 2, 2024

I think this fix is wrong.

As can be seen by https://github.com/junit-team/junit5/blob/84ac590dd9bdee656bfbfd45aa7afbdfd26a3478/documentation/src/test/java/example/TestInfoDemo.java#L24

Junit 5 deliberately passes in different values for Constructor and BeforeEach/AfterEach/Test methods.

So I'll update the approach, allowing both, but they won't share instances between a) constructors and b) test methods.

from okhttp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.