Comments (3)
Attempting a fix to make it just work with constructors also
from okhttp.
I'll update the docs.
The issue is the model of Junit 5 parameters is different for constructors (class) and test and lifecycle methods (class/test method).
It's simplest to only support the latter to avoid confusion of people using the API correctly, but getting weird results.
This log won't make sense, but just recording for my notes.
resource id [engine:junit-jupiter]/[ExtensionLifecycleTest]
init
resource id [engine:junit-jupiter]/[ExtensionLifecycleTest]/[method:testClient2(mockwebserver3.MockWebServer)]
resource id [engine:junit-jupiter]/[ExtensionLifecycleTest]/[method:testClient2(mockwebserver3.MockWebServer)]
setup
resource id [engine:junit-jupiter]/[ExtensionLifecycleTest]/[method:testClient2(mockwebserver3.MockWebServer)]
testClient2
resource id [engine:junit-jupiter]/[ExtensionLifecycleTest]/[method:testClient2(mockwebserver3.MockWebServer)]
tearDown
resource id [engine:junit-jupiter]/[ExtensionLifecycleTest]/[method:testClient2(mockwebserver3.MockWebServer)]
resource id [engine:junit-jupiter]/[ExtensionLifecycleTest]
init
resource id [engine:junit-jupiter]/[ExtensionLifecycleTest]/[method:testClient(mockwebserver3.MockWebServer)]
resource id [engine:junit-jupiter]/[ExtensionLifecycleTest]/[method:testClient(mockwebserver3.MockWebServer)]
setup
resource id [engine:junit-jupiter]/[ExtensionLifecycleTest]/[method:testClient(mockwebserver3.MockWebServer)]
testClient
resource id [engine:junit-jupiter]/[ExtensionLifecycleTest]/[method:testClient(mockwebserver3.MockWebServer)]
tearDown
resource id [engine:junit-jupiter]/[ExtensionLifecycleTest]/[method:testClient(mockwebserver3.MockWebServer)]
from okhttp.
I think this fix is wrong.
As can be seen by https://github.com/junit-team/junit5/blob/84ac590dd9bdee656bfbfd45aa7afbdfd26a3478/documentation/src/test/java/example/TestInfoDemo.java#L24
Junit 5 deliberately passes in different values for Constructor and BeforeEach/AfterEach/Test methods.
So I'll update the approach, allowing both, but they won't share instances between a) constructors and b) test methods.
from okhttp.
Related Issues (20)
- Add a means to reset Postponed Routes HOT 3
- Lets changes our OkHttp 5 async DNS APIs HOT 3
- Test MockWebServer with Loom
- Review tests failing on windows HOT 1
- The request body data added in the NetworkInterceptor was found not included in the capture by Charles. HOT 1
- The request body data added in the NetworkInterceptor was found not included in the capture by Charles
- Gzip/Deflate/Bortli not workin okhttp3 4.12.0/5.0.0-alpha12 HOT 5
- DiskLruCache entry?.currentEditor is allways not null for async requests HOT 1
- Documentation: Clearly state that OkHttpClient should be a singleton HOT 6
- downloading big file midway Report an error java.net.ProtocolException: unexpected end of stream HOT 1
- Investigate Lock vs Synchronized performance HOT 4
- okhttp-coroutines in alpha 13 contains core classes HOT 1
- okhttp3.internal.http2.StreamResetException: stream was reset: CANCEL HOT 1
- HTTPS proxy support HOT 22
- Cannot instantiate MockWebServer on alpha 14: java.lang.NoClassDefFoundError: okhttp3/internal/_UtilJvmKt HOT 3
- Failing while building okhttp version parent-3.6.0 using mvn clean install HOT 1
- QUERY support
- No callbacks: no successful callbacks and no failed callbacks HOT 4
- TaskRunner's concurrent performance exhibits a significant decline in case of poor networks conditions HOT 19
- Calling response.body.string() on a MockWebServer response throws a SocketTimeoutException HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from okhttp.