Giter Club home page Giter Club logo

Comments (6)

JakeWharton avatar JakeWharton commented on June 19, 2024 1

Just remember not to DoS your server! A 500 means it's having problems.

from okhttp.

yschimke avatar yschimke commented on June 19, 2024 1

OK, so two issues.

  1. Your test is setting Retry-After on the Request, not on the MockResponse.
  2. You are using a value of 5, which follows my earlier comment. You will need to implement this yourself. Only 0 is handled immediately.

from okhttp.

yschimke avatar yschimke commented on June 19, 2024

This is expected. You will need to perform retries in your app, or with an Interceptor.

from okhttp.

gauribhoite avatar gauribhoite commented on June 19, 2024

I understood that in the RetryAndFollowUpInterceptor class the 503 is meant to be retried at least once. So the test above was to check if it retried with 503 error. Please help me understand if I'm missing anything?

      HTTP_UNAVAILABLE -> {
        val priorResponse = userResponse.priorResponse
        if (priorResponse != null && priorResponse.code == HTTP_UNAVAILABLE) {
          // We attempted to retry and got another timeout. Give up.
          return null
        }

        if (retryAfter(userResponse, Integer.MAX_VALUE) == 0) {
          // specifically received an instruction to retry without delay
          return userResponse.request
        }

        return null
      }

from okhttp.

yschimke avatar yschimke commented on June 19, 2024

Damn, you are right. Sorry, bad memory on my part.

from okhttp.

gauribhoite avatar gauribhoite commented on June 19, 2024

Thanks! That makes sense now 👍

from okhttp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.