Recipe for buffered value about moshi HOT 7 CLOSED

Interesting. What I like is that we have some tech that makes this relatively straightforward.

from moshi.

@adriancole
Will JsonReader.readJsonValue() now do what you want?

from moshi.

from moshi.

actually another glitch is quoted numbers.. In a perfect world, I could snap off the leaf and the poke at it. Even without this change, it is still fine. Thanks though!

from moshi.

Oh, cool! Thank you for clarifying for me.
This seems straightforward to implement now.

I'll try it out this weekend and see if it's something others want to support.

Edit: realized it was easier than I thought; PR below.

from moshi.

Btw, the alternative is to delegate to the built-in adapters to do the conversions for you (because JsonAdapter.fromJsonValue creates the JsonValueReader).

final JsonAdapter<Double> doubleDelegate;
final JsonAdapter<Long> longDelegate;
fromJson(JsonReader reader) {
  Map<String, Object> object = reader.readJsonValue();
  String type = object.get("type");
  Object value = object.get("value");
  switch (type) {
    case I64:
      value = longDelegate.fromJsonValue(value);
      break;
    case DOUBLE:
      value = doubleDelegate.fromJsonValue(value);
      break;
    default:
      throw new JsonDataException("Unknown type: " + type);
  }
}

from moshi.

Nice. I think we have everything we need for this.

from moshi.