Comments (6)
You can do this yourself!
public final class NonNullJsonAdapterFactory implements JsonAdapter.Factory {
@Override
public JsonAdapter<?> create(Type type, Set<? extends Annotation> annotations, Moshi moshi) {
for (Annotation annotation : annotations) {
if ("NonNull".equals(annotation.getClass().getSimpleName())) { // Or NonNull.class.equals(..)
JsonAdapter<Object> delegate = moshi.nextAdapter(this, type, annotations);
return new NonNullJsonAdapter<>(delegate);
}
}
return null;
}
static class NonNullJsonAdapter<T> extends JsonAdapter<T> {
private final JsonAdapter<T> delagate;
NonNullJsonAdapter(JsonAdapter<T> delagate) {
this.delagate = delagate;
}
@Override public T fromJson(JsonReader reader) throws IOException {
T value = delagate.fromJson(reader);
if (value == null) {
throw new IllegalStateException("value was null!");
}
return value;
}
@Override public void toJson(JsonWriter writer, T value) throws IOException {
if (value == null) {
throw new IllegalStateException("value was null!");
}
delagate.toJson(writer, value);
}
}
}
Putting validation inside Moshi is a dangerous precedent since it has no end to the types of validation people want.
from moshi.
from moshi.
Yep! That'd make for a good one. I don't think you're the first to ask
about it.
On Thu, Sep 10, 2015 at 4:36 PM Tobias Bieniek [email protected]
wrote:
Ah cool, I didn't know that was possible. I guess that's one more reason
for a recipe/samples project or webpage.—
Reply to this email directly or view it on GitHub
#77 (comment).
from moshi.
@JakeWharton I just tried your code but it didn't seem to work as I had expected. What I tried was roughly the following:
public static class TestModel {
@NonNull String a;
String b;
}
Moshi moshi = new Moshi.Builder()
.add(new NonNullJsonAdapterFactory())
.build();
JsonAdapter<TestModel> adapter = moshi.adapter(TestModel.class);
// should work
assertThat(adapter.fromJson("{\"a\":\"test\"}").a).isEqualTo("test");
// should fail
adapter.fromJson("{}");
I was expecting that the second fromJson()
call would throw the IllegalStateException
, but it basically worked just like before. From my limited debugging it seems like the NonNullJsonAdapterFactory#create()
method gets the annotations of the TestModel
class itself (annotations
parameter is empty), but not of its members, so annotating the members doesn't seem to have any effect.
Am I missing something?
from moshi.
I think it's the difference between rejecting null values and requiring non-null values. The example doesn't do anything about absent keys!
from moshi.
adapter.fromJson("{\"a\":null}");
the above call is not throwing anything either...
but you are right, what I actually want to test is whether the API response included the field and that it is non-null.
from moshi.
Related Issues (20)
- warning: Kapt support in Moshi Kotlin Code Gen is deprecated and will be removed in 2.0. HOT 3
- Backend Internal error: Exception during IR lowering HOT 1
- Update Okio to 3.4.0 or higher HOT 4
- Field serialized despite of the Transient annotation
- Kotlin Duration Adapter fails to be generated with codegen
- Undocumented behavior on serialization of non-constructor property with defaults HOT 12
- Better egonomics when replacing nulls with default values HOT 4
- Alternative Enum adapter with default value HOT 8
- Retrofit / enum class / @Json name specified / @FormUrlEncoded API HOT 1
- Bug with ProGuard and R8 HOT 3
- Out of memory error HOT 2
- Support Kotlin Multiplatform HOT 2
- Classes annotated with @JsonClass(generateAdapter = true) are not obfuscated HOT 1
- Moshi Codegen doesn't work with OpenAPI 3.1.0 HOT 7
- `@JsonClass(generateAdapter = true)` fails when class has field with type `Array<Array<T>>` with default
- KSP2 throws `NoSuchElementException` for data classes with `@JsonAdapter(generateAdapter = true)` HOT 1
- Build software better, together
- KSP2 crash when using @JsonQualifier HOT 3
- JDK9 Modules: module reads package com.squareup.moshi from both com.squareup.moshi.adapters and com.squareup.moshi HOT 1
- Moshi Polymorphic adapter fails on Kotlin 2.0 scripts
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from moshi.