Comments (11)
Shouldn't the returned object be String?
from moshi.
This returns an object that can be converted to JSON, not a JSON object itself. Example:
class Point {
double x;
double y;
public Object toJson() {
return Arrays.asList(x, y);
}
public static Object fromJson(Object json) {
List list = (List) json;
return new Point((Double) list.get(0), (Double) list.get(1));
}
}
from moshi.
and what is the advantage of that over returning a String?
from moshi.
The advantage is in how the data looks in the finished JSON document. Imagine we have this:
{
"path": [[1,2],[3,4],[3,2],[1,4]]
}
You could marshall this with this code, without registering any type adapters:
class Shape {
List<Point> path;
}
from moshi.
even
class Shape {
Point[] path;
}
?
from moshi.
Yup; that too.
from moshi.
I am dense, need more explanation. How is the same not achieved if toJson() returned a String instead.
from moshi.
toJson() is meant to customize JSON output to be different from the default representation based on the fields. I presume you meant that Shape class would not need to define toJson() because List and Point[] will automatically get serialized correctly. Well, that is no different from the default behavior based on fields.
from moshi.
Maybe the names could be a bit clearer? I don't have a good recommendation, though.
from moshi.
It’s in, and the final version looks a lot like @Provider
methods.
static class PointAsListOfIntegersJsonAdapter {
@ToJson List<Integer> pointToJson(Point point) {
return Arrays.asList(point.x, point.y);
}
@FromJson Point pointFromJson(List<Integer> o) throws Exception {
if (o.size() != 2) throw new Exception("Expected 2 elements but was " + o);
return new Point(o.get(0), o.get(1));
}
}
from moshi.
@swankjesse Thanks for sharing the adapter snippet!
from moshi.
Related Issues (20)
- Decompiled code still shows annotated name HOT 1
- Option/config to force/require `@Json(name = "…")` annotations on all fields ("Strict mode") HOT 2
- Type mismatch: inferred type is Buffer but BufferedSink! was expected
- Parse double to string; Uncontrollable accuracy
- KSP2 error "Packages cannot be imported" HOT 2
- 速度这块 没有gson 自动生成的插件快 https://github.com/NBXXF/gson_plugin
- Is it possible to fail build when KSP is not configured but @JsonClass(generateAdapter = true) is used?
- warning: Kapt support in Moshi Kotlin Code Gen is deprecated and will be removed in 2.0. HOT 3
- Backend Internal error: Exception during IR lowering HOT 1
- Update Okio to 3.4.0 or higher HOT 4
- Field serialized despite of the Transient annotation
- Kotlin Duration Adapter fails to be generated with codegen
- Undocumented behavior on serialization of non-constructor property with defaults HOT 12
- Better egonomics when replacing nulls with default values HOT 4
- Alternative Enum adapter with default value HOT 8
- Retrofit / enum class / @Json name specified / @FormUrlEncoded API HOT 1
- Bug with ProGuard and R8 HOT 3
- Out of memory error HOT 2
- Support Kotlin Multiplatform HOT 2
- Classes annotated with @JsonClass(generateAdapter = true) are not obfuscated HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from moshi.