Exception on provided class about dagger HOT 7 CLOSED

We need to fix the code generator to reject this. The currently-supported solution is to put a try/catch in your @Provides-annotated method. This is lame, I agree, but it's very transparent.

from dagger.

Now, you can still have this blow up your app, if you throw a RuntimeException from the catch block...

from dagger.

Indeed. This is the universal danger of provides methods. They do
things at run time that are hard to analyse at compile time. We can
only show your wiring to be structurally valid. We cannot prove you
will have no errors at run time.

from dagger.

I mean, it is ok to have Runtime failures like these. My app needs a XmlPullParser to work. I was just suggesting that Dagger doesn't have to interfere with the developer here. But you already know that :)

from dagger.

Should we reject this, or wrap this in a try/catch block and run-time exception in the generated code. It is boiler plate, so it's reasonable to generate, and the try/catch code will be clear within the generated code, just as readable.

Heck, we could even generate run-time exceptions for checked exceptions that wrap them.

Then again, doing so would pretty much pervert the whole approach of checked-exceptions. Whether you're for or against that is sort of a matter of religion.

from dagger.

IMHO, to avoid perversion ("why is this freaking framework throwing something different here?") and avoid a catch (Exception everything) block, which is always bad, you should reject it.

from dagger.

Yeah - I think I agree. Just wanted to put it out for consideration.

from dagger.