_get_column_info() missing 1 required positional argument: 'comment' in SQLAlchemy 1.2.0 about sqlalchemy-redshift HOT 7 CLOSED

Reference commit: https://bitbucket.org/zzzeek/sqlalchemy/commits/fadb8d61babb

from sqlalchemy-redshift.

Would it be crazy to add tests against sqlalchemy master branch to avoid getting caught up on short notice like this in the future?

from sqlalchemy-redshift.

Would it be crazy to add tests against sqlalchemy master branch to avoid getting caught up on short notice like this in the future?

I don't know that it would particularly help, since tests only get run when we new commits get sent to PRs. Months can go by without any activity here.

from sqlalchemy-redshift.

This looks potentially messy if we want to maintain compatibility with SQLA pre-1.2.0 since the new comment parameter is the postgres driver doesn't have a default. We'd need to check the sqlalchemy library version or catch an error to dispatch to a different signature.

@graingert - Do you have thoughts about whether we could make SQAlchemy 1.2.0 the minimum required version for the next release?

from sqlalchemy-redshift.

Months can go by without any activity here.

I think we can cron travis jobs nowadays.

from sqlalchemy-redshift.

For review: #139

from sqlalchemy-redshift.

Addressed in 0.7.1: https://pypi.python.org/pypi?name=sqlalchemy-redshift&version=0.7.1&:action=display

from sqlalchemy-redshift.