Giter Club home page Giter Club logo

Comments (8)

marcosqlbi avatar marcosqlbi commented on June 15, 2024

Thanks for the contribution! I would keep it on hold for a future release, the priority is now fixing issues that are appearing when the configuration is not good (missing Excel, missing OLAP drivers, ...).
For this step (which is part of the v2 roadmap) we also need to figure out a consistent user experience. However, you are free to build your own version and experiment!

from analyzeinexcel.

marcosqlbi avatar marcosqlbi commented on June 15, 2024

@didierterrien I have a question - when you open an existing file with your code, do you change the connection string? It doesn't seem you do that, but maybe I'm missing something.
The build I'm testing now uses COM Interop to control Excel directly. Once tested well (thanks to telemetry we discover a large number of issues...) we'll reach a point where we replace the connection string of an existing Excel file...

from analyzeinexcel.

didierterrien avatar didierterrien commented on June 15, 2024

Hello @marcosqlbi,
No I don't change the connection string. I just check two checkboxes in connection settings :

  • in first tab : refresh data when opening the file
  • in second tab : always use connection file
    This way, the connection string is refreshed from the ODC connection file each time the Excel file is opened. As your tool just updated the ODC file with the Power BI desktop port, it works like a charm.
    The only problem I see may happen if two Power BI reports open two Excel files. As they will share the same ODC file, there will be a conflict. If the OCD file could have the same name than the pbix and could be located in the same folder, there will be no conflict.
    Don't you think replacing the connection string of an existing Excel file can be considered as an attack by some antiviruses ?

from analyzeinexcel.

marcosqlbi avatar marcosqlbi commented on June 15, 2024

Thanks for the explanation!
I think to proceed as planned - if the approach I'm including n v1 works (using COM Interop) we'll get rid of the ODC file and we'll include the connection straight in the Excel file. This should remove the concurrency issue and enable the change of the connection string while we open the file. However, this will be a v3 feature.

from analyzeinexcel.

didierterrien avatar didierterrien commented on June 15, 2024

Hello Marco,

Do you agree if I reuse a part of your code (ODC_Helper) in my external tool ? Of course I will add credits to you.

https://thebipower.fr/index.php/power-bi-sidetools/

Best regards

from analyzeinexcel.

marcosqlbi avatar marcosqlbi commented on June 15, 2024

No problems, it is allowed by the MIT license, I suggest you check it because it has an impact on the license of your tool.
https://github.com/sql-bi/AnalyzeInExcel/blob/master/LICENSE

from analyzeinexcel.

didierterrien avatar didierterrien commented on June 15, 2024

Thanks a lot Marco,
I added the license in the code. I will refer to the web page, to the license and to the GitHub repository of Analyze in Excel in the credits.
Have a nice weekend

from analyzeinexcel.

marcosqlbi avatar marcosqlbi commented on June 15, 2024

Great - thanks!

from analyzeinexcel.

Related Issues (8)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.