Seems like SIGTERM trap doesn’t work about elkx-docker HOT 5 CLOSED

@spujadas thanks for fixing it, however don't you think it is sort of duplication in what's in start.sh already? Perhaps you may want to consider something like in startx.sh instead:

_term() { 
  kill -TERM "$child" 2>/dev/null
}

trap _term SIGTERM

/usr/local/bin/start.sh &

child=$! 
wait "$child"

^ Ref.: https://unix.stackexchange.com/questions/146756/forward-sigterm-to-child-in-bash

So startx.sh shouldn't really "know" how to kill what start.sh is starting, merely forward the term signal to it.

More good stuff in http://veithen.github.io/2014/11/16/sigterm-propagation.html as well.

What do you think?

from elkx-docker.

Well spotted, should now be solved (build in progress), let me know if you're still experiencing this issue.

from elkx-docker.

Clever and infinitely more elegant than my quick and dirty workaround, thanks!
Will implement your solution.

from elkx-docker.

Great stuff, just needed an extra wait ${child} in the _term() function otherwise startx.sh wouldn't wait for start.sh to end before exiting.

from elkx-docker.

Yeah, I didn't experiment with the whole thing, however also in http://veithen.github.io/2014/11/16/sigterm-propagation.html there are two waits; so I think it makes sense.

Thanks for the fix! 🙇

from elkx-docker.