Comments (3)
I agree that the current implementation is not great, I would actually put the client in DIDWeb
from ssi.
Ok -- perhaps there can be two methods: (1) an optional initialize method, in case you want to supply your own reqwest::Client ahead of time, and (2) a getter for the reqwest::Client, which creates the thing if it doesn't exist already. That way, we still get the lazy behavior, but it can be made non-redundant if you care to.
If that sounds good, I'll make a PR.
from ssi.
I don't know if this is the right place to add laziness, I think it's cleaner to have a fn new(client: Option<Client>) -> Self
which either use the provided client or create a new one. Then depending on the use case or environment the DIDWeb
can be constructed lazily, either directly or through DIDMethods
(which would require changes)
from ssi.
Related Issues (20)
- Cleanup unused/undefined compile conditions HOT 1
- "kid" field in JWT-formatted VP HOT 7
- Error during didkit build
- Remove openssl dependency
- The "nbf" field in JWT VCs contains a milliseconds part that will lead to interopt issues with JSON-LD. Same may be true for "iat" and "exp" fields.
- Allow users to chose between JWS and LD proof format
- `json-ld` 0.9.1
- Patch to support UNECE Buy Ship Pay and UNECE Recommendation 21 Contexts HOT 1
- ssi-ldp 0.2.0 fails to compile HOT 6
- Millisecond precision called for by VC data model HOT 2
- Ed25519VerificationKey2018 doesn't support publicKeyJwk apparently HOT 1
- `cargo test --package ssi-vc --all-features` is missing some test vectors HOT 1
- Refactor error in PrimaryDIDURL::from_str; missing crucial validity check
- Credential/Presentation verify fails if serde_json feature arbitrary_precision is enabled. HOT 2
- did:key with `jwk_jcs-pub` multicodec HOT 1
- VC's `termOfUse` type clarification HOT 3
- Looking to get PR approved HOT 3
- Presentations are not really validated in 0.8.0
- `DateTimeEnvironment` impl for `VerificationEnvironment` is too restrictive HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ssi.