Comments (10)
wagenet
commented on July 22, 2024
Looks good to me, but I need to test it.
from abbot.
FrozenCanuck
commented on July 22, 2024
Sounds good. Tom ran the fix on his end and confirmed everything went as expected. Hopefully you'll get the same result.
from abbot.
wycats
commented on July 22, 2024
Does this still need to be merged into 1-4-stable?
from abbot.
FrozenCanuck
commented on July 22, 2024
Yes, it should. I haven't merge the changes because I wanted some others to review. Peter and Tom both said my update looked fine. I can merge it in if you'd like.
from abbot.
wagenet
commented on July 22, 2024
Is this still an issue?
from abbot.
FrozenCanuck
commented on July 22, 2024
it is in 1.4.x, not sure about 1.5 since bundling has been replaced with modules. I haven't looked at the new module logic.
from abbot.
wagenet
commented on July 22, 2024
Ok, since it's only verified on 1.4 feel free to merge yourself or just close it. If there's also an issue on 1.5 we can make a new ticket for it.
from abbot.
FrozenCanuck
commented on July 22, 2024
Sure, I'll merge into 1.4-stable branch and close.
from abbot.
wagenet
commented on July 22, 2024
Guess we should release a new 1.4 at some point.
from abbot.
wagenet
commented on July 22, 2024
@FrozenCanuck, what's the status of this?
from abbot.
Related Issues (20)
- Deprecate require HOT 2
- Unable to proxy sc-server depending on mode.
- Ctrl+c doesn't always quit sc-server on OS X. HOT 5
- empty require statements clobber config:all dependencies
- Yui Compressor 2.4.8 is broken on Windows
- Bundler can't install executables
- HAML exception running sc-build
- Proxy does not support HEAD request
- Using slices (without parameters $width and $height) in a project theme can produce wrong png files HOT 1
- Debug builds still reference .handlebars, but files are renamed .js
- Spriting does not work on Windows HOT 2
- Chance fails on Windows with deep paths HOT 2
- Instructions for using abbot from source don't work HOT 1
- sc-server does not stop with ctrl-c and eats up cpu HOT 6
- Let's have a new line in the build-number command
- sc-build --target option does not include images HOT 1
- sc_require statements remains in the build
- Support for https in sc-server
- Relax the json_pure dependency's version constraint to prevent Bundler conflicts in user applications HOT 2
- Location headers on proxy POSTs badly mangle response.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from abbot.