Consider adding pagination to list views about spring-petclinic HOT 9 CLOSED

hi, can this be worked on?

from spring-petclinic.

According to http://dandelion.github.io/components/datatables/1.1.0/docs/html/#4-2-feature-enablement, dandelion-datatales already supports pagination, and you'd turn on this feature by simply setting pageable attribute to true in related jsp files (e.g. ownerList.jsp), like this:

    <datatables:table id="owners" data="${selections}" row="owner" theme="bootstrap2" 
                      cssClass="table table-striped" pageable="true" info="false" export="pdf">

from spring-petclinic.

For large dataset (this in mostly the case in real application), server side pagination is the best. We may use dandelion pagination support. But DAO have also to be updated.

from spring-petclinic.

Hi @arey @somayaj

Can i take up this issue

from spring-petclinic.

@simrin051, I think so but we may ask confirmation to @snicoll or @dsyer

from spring-petclinic.

Hi @snicoll / @dsyer

Can you please confirm whether i can take up this issue

from spring-petclinic.

Hi @arey

I have commented on the API logs issue. Can you please confirm.

from spring-petclinic.

I don't see the connection with the logs issue. If you want to make a proposal for pagination, go ahead. I think I would prefer to see something that didn't use additional libraries, but I guess we can assess that when we have something to look at. Pet Clinic has no Javascript in the web layer, and that does enable us to concentrate on the Spring side of things and not get caught up in JS dependency churn. Ideally we'd keep it that way IMO, but we can keep the options open while there is no code to review..

from spring-petclinic.

Thanks @dsyer i will take up this issue

from spring-petclinic.