Giter Club home page Giter Club logo

Comments (1)

robertmcnees avatar robertmcnees commented on August 27, 2024

Hi @oulanbator. Thank you for your issue. I see that there are inconsistencies in the links module. If you would like to submit a PR, you could contribute a new OrderNotFoundAdvice similar to the existing EmployeeNotFoundAdvice class. Make sure that the README.adoc is also updated, as some people may be building the code from scratch when going through the tutorial so all relevant instructions need to be declared.

This part seems like a separate issue to me:

Indeed, as we left our code at the end of the tutorial, a bad request on orders (i.e. curl -v localhost:8080/orders/5) send back a 500 error (internal server error) instead of the 404 we should expect.

I didn't have this issue when I went through the tutorial. While the approach between Order and Employee is inconsistent, as you called out, I did not find that it caused an unexpected result. Can you elaborate?

I'll keep this issue open for a future PR.

from tut-rest.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.