Add support for reactive feign clients about spring-cloud-openfeign HOT 30 CLOSED

@spencergibb Sure. That is the goal of all this work. Can you provide the next steps to do?

from spring-cloud-openfeign.

We definitely should find other way if we want Reactive Feign to be released for Spring WebClient.

from spring-cloud-openfeign.

@ryanjbaxter @spencergibb stack into dead end with openfeign repo. Don't see any reasons/benefits to keep code there. No one is reviewing the code except one guy (@kdavisk6) that don't understand how reactive approach should work. It will last for years and from my side looks like sabotage or time killing.
Please, take a look at this issue OpenFeign/feign-reactive#15 and pull request OpenFeign/feign-reactive#18

from spring-cloud-openfeign.

Any updates on this?

from spring-cloud-openfeign.

Hello, 2020!!!
Any updates on this?

from spring-cloud-openfeign.

Added support of hystrix and ribbon to reactive feign
https://github.com/kptfh/feign-reactive

from spring-cloud-openfeign.

@spencergibb You was right about blocking body serialization. After refactoring it can accept Publisher as body. Take a look at shouldReturnFirstResultBeforeSecondSent() test in
https://github.com/kptfh/feign-reactive/blob/master/feign-reactive-core/src/test/java/feign/reactive/allfeatures/AllFeaturesTest.java

from spring-cloud-openfeign.

@kptfh sweet. Any interest in donating that to the project?

from spring-cloud-openfeign.

At this point, just a pull request. There's probably some work to be done in autoconfiguration.

from spring-cloud-openfeign.

@spencergibb Dont you mind about 2 modules?:
spring-reactivefeign
spring-cloud-reactivefeign
The key point here that spring-reactivefeign-core can work out of cloud.

from spring-cloud-openfeign.

Are you saying that spring-reactivefeign-core would be a separate project the spring-cloud-reactivefeign would consume?

from spring-cloud-openfeign.

Yes. As for me it would be the best to incorporate code of feign-reactive-core into spring-boot-starter-webflux as it's actually a thin wrapper over WebClient that just use Feign's MethodMetadata class to discover target client interface. If it's impossible then let it be separate project.
But feign-reactive-cloud is perfect candidate to be included into spring-cloud-openfeign.
Don't want to limit the usage of spring-reactivefeign-core to just spring cloud stack. It will be nice to use it in Kubernetes or Docker Swarm as well.

from spring-cloud-openfeign.

Nothing of feign will go into spring boot. I'm ok with a module here that doesn't have boot dependencies and then one that does. Though the group id will still be Spring Cloud's regular group id.

from spring-cloud-openfeign.

here is the core module pr:
#11

from spring-cloud-openfeign.

Follow along on the PR. We will be looking at integrating this in Finchley.SR1

from spring-cloud-openfeign.

I've left a question on the PR, but I'll bring it up here. Why not submit this into OpenFeign as a module there instead of here? That would be the appropriate place if you wanted this support to be available outside of Spring.

from spring-cloud-openfeign.

Any progress so far?

from spring-cloud-openfeign.

See the PR for details.

from spring-cloud-openfeign.

I highly doubt it is "sabotage or time killing." No need to comment on multiple issues, we see them. I see the ones on OpenFeign as he is taking over for myself and @adriancole. It is a community run project, no full-time developers.

from spring-cloud-openfeign.

I highly doubt it's a community run project. I see only one person :(.
Have you a chance to check PR? Don't spend many time just check this class https://github.com/kdavisk6/feign-reactive/blob/reactive-core/feign-reactive-core/src/main/java/feign/ReactorInvocationHandler.java.
Can't imagine how he is going to process Flux :)

from spring-cloud-openfeign.

Your attitude and comments are very unfortunate.

from spring-cloud-openfeign.

@spencergibb now you're the one who sounds not very polite. @kptfh is offering help on highly demanded feature. Pecking him to death is not helpful.

Maybe you could spend some time and review that @kptfh PR?

from spring-cloud-openfeign.

any updates on this please?

from spring-cloud-openfeign.

Just finished Spring auto configuration
https://github.com/Playtika/feign-reactive

from spring-cloud-openfeign.

I wonder if feign now supports Webflux
@kptfh @spencergibb @ryanjbaxter

from spring-cloud-openfeign.

No it doesnt

from spring-cloud-openfeign.

Playtika feign supports WebFlux. We successfully use it on production for half a year.

from spring-cloud-openfeign.

Just updated ReactiveFeign to support Load balancer and CircuitBreaker. You can use it in 2.0.0 release
Cloud2 module autoconfigurstion

from spring-cloud-openfeign.

No. For now I would suggest #4 (comment)

Marking for team discussion to see if this is something we want to pursue.

from spring-cloud-openfeign.

We're going to defer to the community project mentioned by @kptfh https://github.com/Playtika/feign-reactive

To aid in discovery of community projects, I've created spring-cloud/spring-cloud-commons#686 to add a list to our docs.

from spring-cloud-openfeign.