Understanding the scope of this project about spree_starter HOT 10 CLOSED

• Dockerfile and docker-compose
• React Router Scroll fix

Would either of these be desired? I have the commits ready.

from spree_starter.

Cool! I'm very curious about how you integrated Radium!

I'm curious about the answer the Spark Solutions guys will give to this thread as well. I've been making "features" like extending the react part to the whole checkout process, cart panel, taxon views, turbolinks, and a few others.

I'd be happy to share it if the scope of the project is more than just having a boilerplate and can be even more opinionated.

from spree_starter.

Wow those features sound awesome ridem. I'd really like to see them regardless :)

from spree_starter.

Hi guys :)

Thanks for taking the interest in this project. We always welcome new PRs and features.

The aim of this project is to get the best features every modern e-commerce project needs and which we cannot include in spree core (eg. we don't want to enforce react on all spree users).

@chrisdobler

• Radium - we didn't use it yet, currently we're sticking with CSS modules and bootstrap-loader but we'll take a look at it
• Video files for products right? If so this could be even part of spree core I suppose.

@ridem

• we're very interested in those features you mentioned :)
• we've been playing with turbolinks 5 in a few projects and working on getting the spree admin panel to use them in 3.2
• internally we're building react one-page checkouts/cart panels for our clients (a similar experiences to glossier/bonobos/etc) and we're thinking about doing a simple template that we can open source.
• new API endpoints are required which we'll be part of the next Spree release (3.2). Until then they will be included in this project

from spree_starter.

Hi Damian!

I played around with Radium, and it could be quite complementary with keeping the sass modules as they are right now. For example, I fetch additional content/pages from a headless CMS (Prismic, check this repo - maybe another feature?), and setting the colors, media queries, and so on has been very easy thanks to Radium.

My checkout is also one page with three thirds, made with redux-form, Bonobos style.

I'd have to clean up a bit before submitting PRs, I'll be happy to do that in a few weeks.

from spree_starter.

Hey @ridem, I've been having issues correctly inserting the Radium styleroot into this. How did you work that out?

from spree_starter.

Hi @chrisdobler,

You can wrap the StyleRoot in the layout for example, js/layouts/index.js

So it would be something like this:

// your imports
import { StyleRoot } from 'radium';

export default (props) => {
  return (
      <StyleRoot>
        <HeaderContainer />
        <Flashes fixed={true}/>
        <main id="page">
          {props.children}
          <Footer />
        </main>
      </StyleRoot>
  )
}

from spree_starter.

Thanks @ridem, do you know how I can include the user-agent? Radium always gives me a warning about that, but I'm not sure how to supply it.

from spree_starter.

Hi @chrisdobler, sorry for the delay.

Maybe we should put this discussion in another issue on this project. I think you can follow this link https://github.com/FormidableLabs/radium/tree/master/docs/api#configuseragent to set it up. They provide an example as well. I'm providing the user agent in another way because I'm wrapping another provider upstream.

from spree_starter.

@chrisdobler do you have a fork for docker setup for spark-starter-kit?

from spree_starter.