Giter Club home page Giter Club logo

Comments (1)

ryanvazquez avatar ryanvazquez commented on May 30, 2024

Heroic errors can be persisted between dashboard/panel navigations within the query builder (aka inline), however these errors can't be visualized via the PanelHeaderCorner component (aka the "dogear" notification). Grafana's built-in data-error hook does not trigger the dogear notification.

In order to present the dogear notification to the user, the API response must either be rejected by the datasource via a handled or unhandled promise rejection or an error can be thrown manually. In any case, no time series data will be visualized by Grafana.

This will effectively "break" existing users' experience who may have queries that contain such errors/limits/etc - their panels will show errors but no results sets (when results existed before).

We can address this at the API level and/or the datasource could establish a set of criteria for rejecting Heroic responses if the results are unlikely to be what the user intended - and only break the experience for a narrower set of existing users with malformed queries.

from spotify-heroic-datasource.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.