Comments (6)
I have encountered the same issue - I have tasks that iteratively trigger themselves (aggregating data in 7-day buckets -> 28-day buckets -> N-day buckets). @dlstadther would there be a chance for you to take a look at it when you have a moment (as reviewer of #3122)?
from luigi.
Based on this issue, i understand there to be rendering issues with the SVG visualization here in Luigi. I have no insight to provide towards a solution. I welcome any contributions to the project and I'll do my best to provide reviews (though time has been in short supply for a few years now as my day job no longer uses Luigi).
from luigi.
To my mind, the solution would simply be to revert the changes from #3122, which broke the existing functionality for the sake of someone's aesthetic preference in their use case. Given that the change had been in place for 2 years by the time I upgraded and noticed it, I figured that would be an unpopular solution, and opted to just overwrite that .js file in my local installation.
I didn't see an obvious way to make the fallback to the old behavior in the presence of dependencies between same-named tasks work while keeping the new behavior otherwise, and since the new behavior is useless to me, I didn't have much motivation to put more effort into finding a fix that would preserve it.
from luigi.
@joooeey , being the author of the PR which is causing issues for the use cases mentioned above by @ewallace-RI and @starhel , do you see a clear path to resolution?
from luigi.
I've fixed case with (NaN, NaN) in; #3287
For now I have no time to find solution for non-directly dependent tasks.
from luigi.
I don't use Luigi anymore, so I don't have the time to contribute a tested solution. However, I can see that this line in the visualizer code only checks for direct dependencies to tasks of the same name. To also capture indirect dependencies, the $.each
loop would have to be adjusted to build up an array of known names. Then child_node.name
can be compared with that array.
#3287 is also necessary and it should be checked how that PR interacts with the change I propose in the previous paragraph.
from luigi.
Related Issues (20)
- "Object of type ... is not JSON serializable" when ListParameters of Task instances
- signal only works in main thread of the main interpreter
- Too wide permissions for /tmp/luigi
- dynamic requirements: what's wrong with what I am doing? HOT 3
- `h5py` compatibility with `S3Target` ? HOT 2
- Facing test failures for test/servertest.py on PPC64LE
- Only one worker process being created despite of passing workers as 3 and having simultaneous tasks to perform
- Faulty DONE status assignment HOT 2
- sqla.SQLAlchemyTarget.exist() won't work with SqlAlchemy 2.x version
- TypeError: <Target> object is not iterable when check_complete(dep) is False HOT 3
- Questions about Copilot + Open Source Software Hierarchy
- `JobTask.dump` raises `TypeError` when replacing bytes to string
- Change `subprocess.check_output` option for bytes/string mismatch HOT 1
- Feature request: Include completed task runs in task history
- Bug-Report: Tenacity 8.4.0 HOT 4
- In configuration docs, email_interval_minutes should be email_interval
- In the configuration docs, batch_notifier should be batch_email
- scheduler prune_on_get_work configuration parameter is not documented
- Sequential processing of a specific task with resouces:1 seems to be not working
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from luigi.