Eliminate version from URI (or make configurable) about docker-client HOT 12 CLOSED

Sounds like a good approach, @rohansingh @rculbertson @davidxia ?

from docker-client.

Sure, making it configurable sounds fine to me. I'd prefer not making the actual contents of the string itself configurable, just whether to include it or not.

from docker-client.

Any update on this @tedyoung? I've recently run into the same issue (pulling from a local registry), which in my case happened when upgrading from boot2docker 1.2.0 to 1.3.1.

I can submit a pull request for the change, but want to check that you don't have any work in progress on this issue before starting.

from docker-client.

Still open to a PR from anyone on this. I'm hesitant to do it myself since I haven't actually run into the issue (even though I'm running boot2docker 1.3.1), so I can't repro or verify a fix.

from docker-client.

I took a further look into the root cause of this issue and it appears to be caused by running a local registry on HTTP rather than HTTPS and only seems to occur with docker 1.3.1.

As a workaround you can specify the "--insecure-registry" option on the docker daemon. If you are using boot2docker this can be achieved by:

$ boot2docker ssh
$ # add 'EXTRA_ARGS="--insecure-registry <REGISTRY_HOST>"' to /var/lib/boot2docker/profile
$ sudo /etc/init.d/docker restart

As for this particular issue, I'm concerned that removing the version from the URI could introduce subtle incompatibilities between api versions. As of today the client is coded to work against 1.12 but by providing an option to remove the version and run against the latest api version, there is no guarantee that the client will be continue to be (fully) compatible with the latest version.

I'd like to hear other peoples thoughts on this before continuing.

from docker-client.

@smauel Just to clarify — does this mean that when you omit the version from the URI, you are able to use an insecure registry without specifying --insecure-registry <blah>?

from docker-client.

@rohansingh No, I don't believe so. I only tested omitting the version when I was running against docker 1.3.1, but the --insecure-registry was still required in order to pull the image.

from docker-client.

Any news on this change? I can send a PR if you want making version configurable. I think we need this to be able to connect to as much docker servers as possible or using new features.

from docker-client.

docker-client supports only one version of the API, so specifying other versions will likely cause serialization/deserialization errors. Omitting the version causes docker to default to the latest version. If omitting the version fixed an issue, maybe docker's backwards compatibly was broken. I'm a little hesitant to make this change if it was a workaround for a bug in docker. Maybe we can see if a similar issue occurs again, and then dig into what the most appropriate fix is?

from docker-client.

The version string has been updated from v1.12 to v1.15 which corresponds to Docker 1.3. We've updated the README to explicitly say we've only tested against Docker 1.3.

Making the version string configurable without running tests against all possible versions might mislead users into thinking the client will work with whatever Docker API version they specify. I propose explicitly fixing the version string and stating which version we've tested against for each release.

from docker-client.

PR here #176

from docker-client.

closed by #176

from docker-client.