Implement permissions handling for non-Player CommandSources about spongeforge HOT 6 CLOSED

@zml2008 I like a lot of this, but for the command blocks I think the proposals are flawed. Command block names are also used by some maps (mostly older) to indicate who is saying the /say command from the command block.

Moving forward /tellraw will solve that problem, but we still have many maps with /say and named command blocks would be confusing with permissions.

As long as you address that smallish issue I'm perfectly fine with using the name of the command block.

from spongeforge.

well Sponge is set up so that default permissions match what commands are allowed to vanilla users by default, meaning that any named command block could execute /say. Is that the issue you were worried about?

from spongeforge.

I think so.

from spongeforge.

Well players are identified by their uuid?
And we could use a prefix for command blocks.
@CMDB_<Name>
This guarantees that there will never be collisions between players and commandblocks.
As an alternative we could add a getType method to CommandSource/Subject and leave it to the permission service to deal with it properly. This method would also help for commands whether it can be executed from that source. Ex Arena join is only available to Players regardless of permissions.

from spongeforge.

@ST-DDT I suggest looking at how the permissions api actually works before commenting on issues relating to it.

And for your last example, that's what source instanceof Player is for.

from spongeforge.

This is implemented with PR #215

from spongeforge.