LWTS does not seem to work with liteloader about launchwrappertestsuite HOT 3 CLOSED

So, this got more confusing. It is not related to liteloader. I stripped out basically all of the liteloader code, and tried with vanillagradle (both client and server). I also tried with forge, same issue. Here's the same project, set up with vanillagradle (server): lwts-test-2.zip.

Some debugging has gotten me down to this line of launchwrapper.

final Class<?> clazz = Class.forName(launchTarget, false, classLoader);

For some reason, that is inexplicable to me, on sponge this actually does use the classLoader instance passed in while for me it is using the default class loader (verified using the debugger). I have no clue why. And it's not that the class has already been loaded or something; I tried with -verbose:class and the class is only loaded when that line is hit.

It seems to be that that line is behaving differently on sponge for no discernable reason...

from launchwrappertestsuite.

This is the problem: https://github.com/Mojang/LegacyLauncher/blob/master/src/main/java/net/minecraft/launchwrapper/Launch.java#L97

Launchwrapper automatically adds a classloader exclusion for the package your tweaker is in. You need to put it into a separate package so SomeTest and TestMain are not excluded from Launchwrapper.

This is also what's different for Sponge: We have the tweaker in a separate launch package: https://github.com/SpongePowered/SpongeCommon/tree/bleeding/src/test/java/org/spongepowered/common/launch :)

from launchwrappertestsuite.

Ah, makes sense. Confirmed that that fixes my test program, and it should also fix my actual larger program. Thanks!

from launchwrappertestsuite.