Reported series winner sometimes incorrect after overtime. about get5 HOT 9 CLOSED

Are you seeing this in single-map matches or multiple-map matches?

If it's the 1st it should be much easier to debug.

from get5.

It's happening on single-map matches. No idea what the results of a multi-map series would be because we haven't tested them.

from get5.

I was unable to reproduce it, but I've made some changes that may fix this.

My suspicion is that the round_end event could have been firing after cs_win_panel_match, meaning if:

• team 1 wins a round, score becomes 10-15 from 9-15
• team 2 wins the last round, score becomes 10-16

the "last round winner" would be the wrong team, which is how the cs_win_panel_match callback determined the winner before.

I would imagine this could happen in anywhere up to 50% of cases. Since there is some degree of momentum to the game, it was more likely around 25%.

from get5.

This issue is still present http://i.imgur.com/dy2G6oD.jpg

from get5.

@techlover1 can you give a version or commit that the servers was running in that screenshot?

from get5.

@splewis version 0.0.1-dev+79

from get5.

I believe I've fixed this issue in 00e87bb now.

The issue was overtime-halftime side swaps not being done, which should work now.

from get5.

@splewis that's great to hear. Thanks for looking deeper into this.

from get5.

@splewis awesome! I'll be updating everything tomorrow

from get5.