The earlylast argument is not available in the StreamFragmen

StreamFragmentWidthAdapter.make missing earlylast argument about spinalhdl HOT 2 OPEN

louiecaulfield commented on June 2, 2024

StreamFragmentWidthAdapter.make missing earlylast argument

from spinalhdl.

Comments (2)

louiecaulfield commented on June 2, 2024

Sorry to open this issue again (should I start a new one?), but further implementing the width adapter, I noticed the dataMask is not available when using the make convenience methods as the Area, containing the datamask, is not returned.

I worked around it by defining my own make functions as below, but I'm not so satisfied by the style.

class StreamFragmentWA
object StreamFragmentWA {
  def apply[T <: Data,T2 <: Data](input : Stream[Fragment[T]],output : Stream[Fragment[T2]], endianness : Endianness, earlyLast : Boolean = false): Bits = {
    StreamFragmentWA(input, output, endianness, false, earlyLast)
  }

  def apply[T <: Data,T2 <: Data](input : Stream[Fragment[T]],output : Stream[Fragment[T2]], endianness : Endianness, padding : Boolean, earlyLast : Boolean): Bits = {
    StreamFragmentWidthAdapter(input, output, endianness, padding, earlyLast).dataMask
  }

  def make[T <: Data, T2 <: Data](input : Stream[Fragment[T]], outputPayloadType : HardType[T2], endianness : Endianness, earlyLast : Boolean) : (Stream[Fragment[T2]], Bits) = {
    val ret = Stream(Fragment(outputPayloadType()))
    val mask = StreamFragmentWA(input,ret,endianness,false,earlyLast)
    (ret, mask)
  }
}

The in my module I write

val (axi_stream, axi_mask) = StreamFragmentWA.make(fifo.io.pop,
                                                    Bits(io.axi.config.dataWidth bits),
                                                    LITTLE,
                                                    earlyLast = true)

from spinalhdl.