Comments (4)
spencerahill
commented on June 2, 2024
Yikes, good catch. I'll fix this right now.
from aospy.
spencerkclark
commented on June 2, 2024
Thanks!
from aospy.
spencerahill
commented on June 2, 2024
02a8a8f should resolve this. I implemented the switch you suggested and also improved the to_radians function itself, both the threshold for conversion and by trying to use the embedded 'units' metadata.
This and the other conversion methods could definitely be improved, potentially even a conversions class or module created.
(Yet another reminder of the need for formal automated tests, both so that we would have caught this in the first place and that I should have added some for the new code in order to be sure it actually works! One day...)
Let me know if there's still any problems, otherwise please close.
from aospy.
spencerkclark
commented on June 2, 2024
This looks great; things are working as expected now. I like the additional improvements to to_radians! Thanks again.
from aospy.
Related Issues (20)
- Error when passing non-default date ranges to `calc_suite_specs` HOT 6
- BOUNDS_STR and TIME_BOUNDS_STR HOT 14
- Daily output data HOT 1
- Perform calculations on subset of levels HOT 2
- recalculate HOT 1
- Calculations on only one variable HOT 3
- Towards v0.3 release HOT 15
- Use `stable` and `master` as our two main branches, rather than `master` and `develop` HOT 1
- Add support for zarr HOT 5
- Improve logging when calcs submitted in parallel
- Potentially use intake for describing/finding data on disk (i.e. what DataLoaders do)
- Failing tests in CI, but for some builds still come back as green
- New failure in test_apply_time_offset HOT 5
- Need to fix warnings due to recent updates to dependencies
- Move CI over to Azure pipelines HOT 1
- Use "black" tool for enforcing style
- Infer surface area from lat + lon if none provided. HOT 1
- Should we move aospy repository to its own 'aospy' organization? HOT 2
- Python errors in docs builds HOT 1
- YAML-based specification of aospy objects HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from aospy.