Giter Club home page Giter Club logo

Comments (6)

eschirmacher avatar eschirmacher commented on August 15, 2024

Hi Giorgio,

I did not write a documentation file for the lifetable constructor. I'll send in a pull request shortly.

But I also wanted to mention another issue I ran across. When checking the package via the "Check" button in RStudio I got an error message when trying to build the vignette "an_introduction_to_lifecontingencies_package.Rnw"

Error: processing vignette 'an_introduction_to_lifecontingencies_package.Rnw' failed with diagnostics:
chunk 5 (label = structure3)
Error : evaluation nested too deeply: infinite recursion / options(expressions=)?
Execution halted

This error occurs when you try to evaluate the following function in R:
showMethods(classes=c("actuarialtable","lifetable"))

Take a look and see if you get a similar error.

Thanks,

Ernesto

from lifecontingencies.

spedygiorgio avatar spedygiorgio commented on August 15, 2024

Hi Ernesto, I did not find that error (but I compiled the package on 3.2.2.). What it seems strange to me is that TRAVIS CI seems all ok. What I can do is to compare the CRAN published and the committed version of lifecontingencies class... I think it is a weird issues.

from lifecontingencies.

spedygiorgio avatar spedygiorgio commented on August 15, 2024

I probably found the error... There was need to write an initialize method for both lifetable and actuarialtable classes

from lifecontingencies.

eschirmacher avatar eschirmacher commented on August 15, 2024

Since I wrote an initialize method for lifetable I also was supposed to write the user documentation for it. That is the real issue. I have not written an initialize method for actuarialtable. Once I do that I'll also write the accompanying documentation file.

I was also working with with a couple of other branches on my local git repository and since I'm fairly new at git I got myself confused with the branches and commits.

I have re-initialized my fork of lifecontingencies and later today I'll submit a pull request for the documentation of lifetable.

Would you mind closing the current pull request?

thank you very much!

from lifecontingencies.

spedygiorgio avatar spedygiorgio commented on August 15, 2024

the issue is closed, I also sligthy modified the test (making lifetables to be created by new("lifetable"))

from lifecontingencies.

eschirmacher avatar eschirmacher commented on August 15, 2024

Ok. Since you have lifetables created by new then there is no need for a lifetable function that constructs the object (all taken care within the initialize method).

There is some duplication of code for the initialize method for new lifetable and new actuarialtable.

from lifecontingencies.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.