Confusion in inst2vec_preprocess.py when reading code about ncc HOT 6 CLOSED

The assertion is correct. It checks for different regular expressions, and if there is no match continues to the next one. If the last check fails, then check is None and the assertion should fail. In any other case, the check is successful and execution should continue.

Why do you think it should be the opposite?

from ncc.

I think that if it goes to the branch if arg_list_ is None: , that check must be None (as it found no "( )"). And assert will meet False and assertion will fail.

But in this case, assertion in this brach will always fail. Does it mean that this brach should just not be executed?

from ncc.

Or it is the debug code left after testing the function find_outer_most_last_parenthesis. If it is that case, I understand it and the comments there. When I first see it, I just got confused and didn't realize the meaning of this code.

from ncc.

Yes, the assertion and regexp in the branch is a sanity check meant to make sure that find_outer_most_last_parenthesis didn't miss an empty argument list somewhere.

from ncc.

Thanks for your reply! Thanks for your outstanding work! I really learn a lot from it.

from ncc.

Happy to help :)

from ncc.