Cannot save the user model twice in the same request about laravel-permission HOT 5 OPEN

1. How are you registering roles to the model? It would be helpful to see what your code is for that, since it should have already finished persisting things and letting go of what was specified to be attached. Seeing your code would help.
2. In your listener, perhaps you can call $user->fresh() to have a clean unique instance before updating its properties and saving?

from laravel-permission.

Hi, here is a simple code to reproduce created a new empty laravel 11 project.

<?php

use Illuminate\Support\Facades\Route;
use Spatie\Permission\Models\Role;
use Spatie\Permission\Models\Permission;

Route::get('/', function () {
    $user = new \App\Models\User([
        'name' => \Illuminate\Support\Str::random(),
        'password' => \Illuminate\Support\Str::random(),
        'email' => \Illuminate\Support\Str::random() . '@example.com',
    ]);
    if (Role::where('name', 'writer')->doesntExist()) {
        $role = Role::create(['name' => 'writer']);
        $permission = Permission::create(['name' => 'edit articles']);
        $role->givePermissionTo($permission);
    }
    $user->assignRole('writer');

    $user->save();
    $user = $user->fresh();
    $user->save();
});

from laravel-permission.

Thanks for the code sample.

Yes, if you're creating a User with new, then it is not yet persisted into the database, and attached pivots are getting duplicated when calling save().

However, if you first ->save() that unpersisted User before calling assignRole()/etc, subsequent saves will not be problematic.

Also, if you use User::create() instead of new User, none of these problems occur.

from laravel-permission.

@erikn69 I'm interested in your thoughts about how to avoid these "Duplicate entry" errors when attaching to an un-persisted model.

Ref: #2419 #2420 #2574
Ref: https://github.com/laravel/framework/blob/master/src/Illuminate/Database/Eloquent/Relations/Concerns/InteractsWithPivotTable.php

from laravel-permission.

I think it is a problem that has always been present.
A validation could be added,
I would have to do tests, I think that adding wasRecentlyCreated would solve it

from laravel-permission.